Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport reattachment of unattached segment history elements #1504

Closed
Sapphron opened this issue Oct 6, 2019 · 14 comments
Closed

Backport reattachment of unattached segment history elements #1504

Sapphron opened this issue Oct 6, 2019 · 14 comments
Labels
area: livesplit-core Progress that has been made in livesplit-core that is missing from the original LiveSplit. bug Reports unexpected behavior (or for a PR: fixes unexpected behavior). help wanted Issue requires advanced knowledge.

Comments

@Sapphron
Copy link

Sapphron commented Oct 6, 2019

Hello, this has really been bugging me over the past few months. I haven't been using LiveSplit much so it hasn't affected me greatly, but I decided it was time to ask about what the heck keeps happening.
Each time I finish a run and have the ending split, I press 1 which is my split key to save it. It shows all of the fields with Deltas saying +0.0 like this: https://drive.google.com/file/d/1hc8xQRCnNRWqd7ZwoD3BssoPAQ-ivr0i/view?usp=sharing
And if I try to save it without trying to press 1 about ten times so it finally saves for some reason, it just shows this error: https://pastebin.com/zHFyzQqw
This is really obnoxious. I tried redownloading LiveSplit to see if I had an old version or something, but that wasn't it.

@CryZe
Copy link
Contributor

CryZe commented Oct 6, 2019

Can you send me those splits? They seem corrupted in some way that is completely unexpected to LiveSplit.

@Sapphron
Copy link
Author

Sapphron commented Oct 6, 2019

Yeah, I totally forgot to send them in the first place, sorry. The reason it's named "test.lss" is because I didn't want to screw up my main split file terribly, but it does the exact same thing. And this type of thing has happened on other livesplit configurations too for some reason... https://www.dropbox.com/s/ln8t7ny6cj7uudi/test.lss?dl=1

@CryZe
Copy link
Contributor

CryZe commented Oct 6, 2019

How do I replicate it crashing exactly? Just saving doesn't seem to be enough.

@Sapphron
Copy link
Author

Sapphron commented Oct 6, 2019

For me, finishing the "run" and then trying to save while it has the +0.0's on screen does that error for me. In the "Save Splits" section.

@Sapphron
Copy link
Author

Sapphron commented Oct 6, 2019

[double post, sorry]
It fixed itself, somehow?? It doesn't do it anymore

@Sapphron
Copy link
Author

Sapphron commented Oct 6, 2019

https://www.dropbox.com/s/lbtgaxavm9wcvsd/Super%20Metroid%20-%20Low%25%20Ice%20-%20Copy.lss?dl=1 THIS one does it. Sorry for the confusion
Edit: and when I try to exit it without saving, it doesn't exit at all. If you try to save it, the error happens.

@CryZe
Copy link
Contributor

CryZe commented Oct 6, 2019

Oh wow, yeah I'm seeing it with this file now too.

@Sapphron
Copy link
Author

Sapphron commented Oct 6, 2019

For some reason, hitting 1 (split key) over and over fixed the "test.lss" file...

@CryZe
Copy link
Contributor

CryZe commented Oct 6, 2019

Did you manually modify the XML in some way? The data in there seems inconsistent.

@Sapphron
Copy link
Author

Sapphron commented Oct 6, 2019

The only thing I know that I did was modify this line:
< Platform usesEmulator="False" >
99.9% sure I didn't modify anything else.

@wooferzfg
Copy link
Member

Here's a fixed version of your splits file: https://www.dropbox.com/s/6hibrjfh22hrzan/SM_Low_Ice_Fixed.lss?dl=0

@Sapphron
Copy link
Author

Sapphron commented Oct 6, 2019

https://www.dropbox.com/s/mvojaqic03txps1/Super%20Metroid%20Ancient%20Chozo%20-%20Any%25BROKEN.lss?dl=1
https://www.dropbox.com/s/v5zmorygb4kc8kq/Super%20Metroid%20Hermit%20Kingdom%20-%20Any%25BROKEN.lss?dl=1
These two are also broken. Out of my 52 split files, only 3 are corrupt, I'm guessing one was corrupt and I used that one unknowingly and the other ones broke.
Also, how did you fix it? Thank you so much!

@CryZe
Copy link
Contributor

CryZe commented Oct 7, 2019

Here's the changes that need to be backported for this to the original LiveSplit. LiveSplit/livesplit-core#252

@CryZe CryZe added bug Reports unexpected behavior (or for a PR: fixes unexpected behavior). help wanted Issue requires advanced knowledge. area: livesplit-core Progress that has been made in livesplit-core that is missing from the original LiveSplit. labels Oct 7, 2019
@CryZe CryZe changed the title LiveSplit not saving any splits/having errors upon saving Backport reattachment of unattached segment history elements Oct 7, 2019
@TheTedder
Copy link
Contributor

I'm gonna tackle this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: livesplit-core Progress that has been made in livesplit-core that is missing from the original LiveSplit. bug Reports unexpected behavior (or for a PR: fixes unexpected behavior). help wanted Issue requires advanced knowledge.
Projects
None yet
Development

No branches or pull requests

4 participants