Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix networking tests that use OpenSSL #308

Closed
CryZe opened this issue Mar 2, 2020 · 1 comment · Fixed by #733
Closed

Fix networking tests that use OpenSSL #308

CryZe opened this issue Mar 2, 2020 · 1 comment · Fixed by #733
Labels
blocked Progress is blocked and can't progress. ci Affects the Continuous Integration. code quality Affects the quality of the code. networking Communication with an API is required. priority: low This is a low priority issue. suitable for contributions The issue is suitable those who are contributing to livesplit-core.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Mar 2, 2020

In cross they removed OpenSSL from all the docker containers as they didn't want to keep maintaining OpenSSL anymore. So this broke our tests on mips and powerpc, as these are the platforms where we use OpenSSL. For now I've deactivated the tests, but we likely want to either switch those to rustls (which doesn't support those platforms yet, but might in the future). Alternatively we could maintain our own containers, but that's probably overkill. The likeliest short term solution should be to adjust our CI script to run the tests on those platforms again, but instead of using --all-features it compiles all features except networking for them.
@CryZe CryZe added needs further discussion It is unclear how to progress without making further decisions. ci Affects the Continuous Integration. code quality Affects the quality of the code. networking Communication with an API is required. suitable for contributions The issue is suitable those who are contributing to livesplit-core. labels Mar 2, 2020
CryZe added a commit to CryZe/livesplit-core that referenced this issue Mar 2, 2020
@CryZe
Skip the networking tests for now
cfdfe76 
This is tracked in:
LiveSplit#308
@CryZe CryZe added the priority: low This is a low priority issue. label May 30, 2020
@CryZe
Copy link
Collaborator Author

CryZe commented Nov 25, 2021

We probably just want to wait on rustls to support these platforms tbh.

@CryZe CryZe added blocked Progress is blocked and can't progress. and removed needs further discussion It is unclear how to progress without making further decisions. labels Jan 1, 2022
@CryZe CryZe linked a pull request Oct 24, 2023 that will close this issue
Activate networking tests again #733
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Progress is blocked and can't progress. ci Affects the Continuous Integration. code quality Affects the quality of the code. networking Communication with an API is required. priority: low This is a low priority issue. suitable for contributions The issue is suitable those who are contributing to livesplit-core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Activate networking tests again CryZe/livesplit-core
1 participant
@CryZe