x265 fails to build with cmake 4.0

[hbiyik]

Describe the Bug

2025-04-02T17:34:52.1199976Z CMake Error at third-party/FFmpeg/x265_git/source/CMakeLists.txt:10 (cmake_policy):
2025-04-02T17:34:52.1200615Z -- cmake version 4.0.0
2025-04-02T17:34:52.1201570Z   Policy CMP0025 may not be set to OLD behavior because this version of CMake
2025-04-02T17:34:52.1202259Z   no longer supports it.  The policy was introduced in CMake version 3.0.0,
2025-04-02T17:34:52.1202799Z   and use of NEW behavior is now required.
2025-04-02T17:34:52.1203069Z 
2025-04-02T17:34:52.1203329Z   Please either update your CMakeLists.txt files to conform to the new
2025-04-02T17:34:52.1203958Z   behavior or use an older version of CMake that still supports the old
2025-04-02T17:34:52.1204563Z   behavior.  Run cmake --help-policy CMP0025 for more information.
2025-04-02T17:34:52.1204934Z 
2025-04-02T17:34:52.1204938Z 
2025-04-02T17:34:52.1205252Z CMake Error at third-party/FFmpeg/x265_git/source/CMakeLists.txt:16 (cmake_policy):
2025-04-02T17:34:52.1205972Z   Policy CMP0054 may not be set to OLD behavior because this version of CMake
2025-04-02T17:34:52.1206648Z   no longer supports it.  The policy was introduced in CMake version 3.1.0,
2025-04-02T17:34:52.1207178Z   and use of NEW behavior is now required.
2025-04-02T17:34:52.1207446Z 
2025-04-02T17:34:52.1207708Z   Please either update your CMakeLists.txt files to conform to the new
2025-04-02T17:34:52.1208344Z   behavior or use an older version of CMake that still supports the old
2025-04-02T17:34:52.1209089Z   behavior.  Run cmake --help-policy CMP0054 for more information.

full log: https://productionresultssa18.blob.core.windows.net/actions-results/3ae8b4c2-4433-4ad7-af05-e5c96e8a730f/workflow-job-run-5186cbe4-4e8b-5758-aed1-215615080f61/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-04-02T18%3A52%3A15Z&sig=B6LgMBzE2wQxR4PLCOm5LeI21Jc6HGURlSYlI90sfIM%3D&ske=2025-04-03T05%3A38%3A59Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-04-02T17%3A38%3A59Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-01-05&sp=r&spr=https&sr=b&st=2025-04-02T18%3A42%3A10Z&sv=2025-01-05

Expected Behavior

No response

Additional Context

No response

[ReenigneArcher]

Probably should open this with x265 instead?

[ReenigneArcher]

Actually, looks like we need to update the branch that the x265 submodule is pointing to. This may already be fixed upstream.

[hbiyik]

Actually, looks like we need to update the branch that the x265 submodule is pointing to. This may already be fixed upstream.

yeah, i also thought so, the submodule needs to be updated but this change is very recent, i am not sure libx265 has the fix already

edit: LizardByte-infrastructure/x265_git@b354c00

[ReenigneArcher]

Hopefully there is a new tagged version soon.

[ReenigneArcher]

Just tested the latest master, and even though it appears there was an attempted fix it does not build without error either.

Here's the upstream issue: https://bitbucket.org/multicoreware/x265_git/issues/988/build-fails-with-cmake-400

There are also other issues with the latest version as well, which I'm not sure how to solve quite yet.
https://github.com/LizardByte/build-deps/actions/runs/14255065454?pr=415

[ReenigneArcher]

Looks like it's closer, but still getting an error on Windows.

CMake Error at third-party/FFmpeg/x265_git/source/dynamicHDR10/CMakeLists.txt:13 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

I think it's good for the Unix builds. Cross compiling Linux fails due to a mirror issue though so can't confirm 100% yet. https://github.com/LizardByte/build-deps/actions/runs/14561072283/attempts/1

[hbiyik]

I think it's good for the Unix builds. Cross compiling Linux fails due to a mirror issue though so can't confirm 100% yet. https://github.com/LizardByte/build-deps/actions/runs/14561072283/attempts/1

Yeah thats also fine, 3.5 policy can at least be mitigated with ENV variable or cmake argument.

Actually half of the packages failed building in my repo after migrating cmake 4.0, i just forced cmake 3.5 compat for everything.

The submodule revision in sunshine repo is not updated the latest build deps rights?

[ReenigneArcher]

The submodule revision in sunshine repo is not updated the latest build deps rights?

It's updated to the latest, but it hasn't been updated since March 12th.

[ReenigneArcher]

I've created an issue upstream about the dynamicHDR10 build failure: https://bitbucket.org/multicoreware/x265_git/issues/993/dynamichdr10-build-fails-with-cmake-4x

[ReenigneArcher]

Fixed by #448