fix(localize): Allow empty xgettext extraction#6
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 163 166 +3
=========================================
+ Hits 163 166 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
|
If xgettext produces no messages, x_extract now detects that the .pot/.po file wasn't created, prints a notice and returns early instead of attempting to rewrite the header. Adds a unit test to verify extraction succeeds when xgettext writes no messages and no template file is produced. This prevents errors when projects have no translatable strings.
ReenigneArcher
force-pushed
the
fix/localize/allow-empty-localization
branch
from
103f243 to
831e122
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If xgettext produces no messages, x_extract now detects that the .pot/.po file wasn't created, prints a notice and returns early instead of attempting to rewrite the header. Adds a unit test to verify extraction succeeds when xgettext writes no messages and no template file is produced. This prevents errors when projects have no translatable strings.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage