New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake build and build instructions, fix compiler warnings #1

Merged
merged 3 commits into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@dvejmz
Copy link
Contributor

dvejmz commented Oct 10, 2017

A number of minor changes have been made:

  • Cmake build instructions on README updated as cmake --build . doesn't work in all platforms, as it throws an Error: could not load cache error (perhaps a CLion thing?). cmake .. inside a build directory should always work though.
  • Removed a couple of non-existent files from Cmake config file: lib.h, lib.c. Cmake build was failing because of this.
  • Ran clang against the library with -Wall -Wextra and fixed the couple of warns that popped up

Lib compiles now without warns. Tested with the example file included with the repo.

@LloydLabs

This comment has been minimized.

Copy link
Owner

LloydLabs commented Oct 13, 2017

Hi there, I've merged your pull request.

Thank-you for your contribution!

@LloydLabs LloydLabs merged commit f4a2252 into LloydLabs:master Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment