Permalink
Commits on Mar 9, 2017
  1. Fix exit status expectations in user acceptance test

    * Add missing expectations on localeapp execution return status;
    * Remove steps testing that help is not displayed: most probably it was
      a way to ensure this command exist, but we have a dedicated test for
      unknown commands (`bad_command.feature'), and we should generally test
      what known commands do, not what they don't do.
    tjouan committed with thibaultdalban Mar 8, 2017
  2. Fix setup (log directory) in `pull' command tests

      When `log' directory does not exist, the `pull' command fails, but we
    never noticed it because we used `When I run` cucumber step from aruba
    instead of `When I successfully run`, and we forgot to test the exit
    status.
    tjouan committed with thibaultdalban Mar 8, 2017
  3. Improve user acceptance test features

    * Remove comments;
    * Fix indentation on `And' steps, while we understand the intent, it's
      not conventional and make it difficult to edit files with an
      auto-indenting editor;
    * Remove extra empty lines;
    * Remove "useless" descriptions: it is meant to be more complete than
      the feature name, or the scenario name, when we need more than one
      line to describe the business rules, and is not mandatory;
    * Improve some scenario names: scenario should describe the expected
      behavior, not just repeat what we do in `Given' steps.
    * Simplify features name and make them more explicit (just mention the
      tested command).
    tjouan committed with thibaultdalban Mar 8, 2017
Commits on Mar 8, 2017
  1. Update changelog for 2.1.0 and 2.1.1 releases

    [ci skip]
    tjouan committed with thibaultdalban Mar 8, 2017
  2. Run tests with actual dependencies on travis CI

      We specified builds only with custom gemfiles, to test against
    specific releases of i18n (0.4, 0.5, 0.6 and 0.7). But build with the
    standard gemfile is missing, we need to test with i18n actual version
    too (0.8 currently).
    tjouan committed with thibaultdalban Mar 8, 2017
Commits on Mar 7, 2017
  1. Read API key from environment in generated configs

      Change installers so that none of them will write the API key in the
    generated configuration file, when using `install' CLI command.
    tjouan committed with thibaultdalban Feb 17, 2017
  2. Fix `Localeapp::CLI::Install::DefaultInstaller#execute' spec

      The first examples in this spec all belongs to the context "when key
    validation fails" as we mock the SUT to deliberately simulate a failing
    key validation.
    tjouan committed with thibaultdalban Jan 31, 2017
  3. Update `install' subcommand github option description

    * Mention that `.gitignore' will be modified too;
    * Change wording because files are not overwritten, we just append some
      content.
    tjouan committed with thibaultdalban Jan 31, 2017
  4. Improve `Localeapp::CLI::Install::DefaultInstaller' specs

    * Remove dead code;
    * Refactor.
    tjouan committed with thibaultdalban Jan 31, 2017
  5. Remove config files for tools not used by project

      Those are config files for external tools which may have been used by
    this gem authors, but they shouldn't be maintained in the gem sources
    repository.
    tjouan committed with thibaultdalban Jan 31, 2017
  6. Remove unused file

    tjouan committed with thibaultdalban Jul 23, 2015
  7. Fix the inclusion of GLI DSL in the global namespace

      We need to include `GLI::App' or `GLI' in a wrapper module, else the
    methods from `GLI::AppSupport' are defined in the global namespace.
    tjouan committed with thibaultdalban Jan 30, 2017
  8. Improve `Localeapp::CLI::Install#execute' specs

    * Remove dead code;
    * Remove contrived mocks on `Localeapp::CLI::Install#installer' which
      might better be a private method, replace with mocks on installers
      class methods, since we already depended on class names anyway;
    * Refactor.
    tjouan committed with thibaultdalban Jan 30, 2017
Commits on Jan 18, 2017
  1. Bump patch version

    tjouan committed Jan 18, 2017
  2. Merge pull request #218 from Locale/feature/support-ruby_24

    Support ruby 2.4
    thibaultdalban committed on GitHub Jan 18, 2017
  3. Support ruby 2.4

    tjouan committed Jan 6, 2017
  4. Workaround calls to `FakeWeb::StubSocket#close'

        error: undefined method `close' for
        #<FakeWeb::StubSocket:0x000008079ed680>
    tjouan committed Jan 3, 2017
Commits on Jan 17, 2017
  1. Bump minor version

    tjouan committed Jan 17, 2017
  2. Merge pull request #215 from Locale/feature/simplify-dependencies-run…

    …time
    
    Simplify runtime dependencies in gem specification
    thibaultdalban committed on GitHub Jan 17, 2017
  3. Simplify runtime dependencies in gem specification

      In `4fccfba' we added version requirements for a few gems, most
    probably to workaround build errors on old MRI release. However most of
    these requirements are too strict and prevent usage with rails 5 or
    `json' and `rest-cient' gems.
    
    * Remove `mime-types' gem dependency requirement: not a direct
      dependency;
    * Remove version requirements for `json' gem and `rest-client' gem.
    tjouan committed Jan 5, 2017
  4. Merge pull request #214 from Locale/feature/remove-support-rubies_old

    Remove support for ruby 1.9 and ruby 2.0
    thibaultdalban committed on GitHub Jan 17, 2017
Commits on Jan 11, 2017
  1. Remove support for ruby 1.9 and ruby 2.0

      This change is based on original work from David Rodríguez, thanks!
    See original version at:
    
      #203
    tjouan committed Jan 5, 2017
Commits on Jan 10, 2017
  1. Merge pull request #216 from Locale/feature/fix-updater-yaml_dump

    Fix spec on `Localeapp::Updater' YAML dump formatting
    thibaultdalban committed on GitHub Jan 10, 2017
  2. Fix spec on `Localeapp::Updater' YAML dump formatting

    * Fix the condition for ruby platform (`!RUBY_PLATFORM == "jruby"' will
      *always* return `false') and compare with `java' so that this test is
      run;
    * Fix incorrect expectation, this test never passed but we could not
      notice as it was never executed:
      + Remove explicit match on `!' (non-specific tag property);
      * Remove quotes from pattern (we don't care about their presence or
        which kind of quote is used in this test).
    * Refactor regexp pattern (repetition).
    tjouan committed Jan 6, 2017
  3. Merge pull request #213 from Locale/feature/improve-travis-build

    Improve travis CI build
    thibaultdalban committed on GitHub Jan 10, 2017
Commits on Jan 9, 2017
  1. Remove travis CI build on `jruby-head'

      We added it in `9f144f3' to workaround RVM bugs in old travis CI
    images and be able to test on recent jruby release at the time (jruby
    9000.dev).
    
      However, since we now use more recent travis CI images, specifying
    `jruby' is enough to get a stable jruby release (more recent than
    specifying `jruby-head' on the old images).
    tjouan committed Jan 6, 2017
  2. Change build order for MRI rubies on travis CI

      So that we get the most interesting build results faster (recent
    rubies).
    tjouan committed Jan 6, 2017
  3. Fix ruby versions used in travis CI builds

      Travis CI uses RVM to manage ruby versions, but unfortunately it is
    not up to date and install old release in most cases (2.4.0rc1 for 2.4,
    and 2.3.1p112 for 2.3, etc.).
    
      It's not possible to update RVM when we use a matrix (multiple ruby
    versions, multiple gemfiles), so we have to specify and maintain exact
    ruby versions where needed.
    tjouan committed Jan 6, 2017
  4. Configure travis CI to use a non-obsolete env

      As of 20160916, default travis CI env use obsolete releases for jruby:
    
        jruby-9.0.5.0
        jruby-9.0.4.0
        jruby-9.0.3.0
        jruby-9.0.1.0
        jruby-9.0.0.0.pre2
        jruby-9.0.0.0.pre1
        jruby-9.0.0.0
        jruby-1.7.9-d19
        jruby-1.7.20
        jruby-1.7.19
        jruby-1.7.18
        jruby-1.7.17
        jruby-1.7.11
    
      jruby stable versions are now 9.1.x, and the last supported release on
    1.7 was 1.7.26 (old stable).
    
      Forcing the usage of their "Ubuntu 14.04" image, which seems more
    actively maintained, is done by setting `sudo' to `required' and `dist'
    to `trusty'. Note: setting `sudo' to `false' uses "Ubuntu 14.04" image,
    but a different version that would bring jruby 1.7.26.
    tjouan committed Sep 16, 2016
Commits on Jan 6, 2017
  1. Merge pull request #211 from Locale/feature/remove-cli_wrapper-load_p…

    …ath_mutation
    
    Remove ruby load path mutation from CLI wrapper
    michaelbaudino committed on GitHub Jan 6, 2017
  2. Merge pull request #212 from Locale/feature/remove-dependencies-redcloth

    Remove unused `RedCloth' gem dependency declaration
    michaelbaudino committed on GitHub Jan 6, 2017