Skip to content

Fix recomputeTree example in README.md #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2021
Merged

Fix recomputeTree example in README.md #47

merged 2 commits into from
Jan 6, 2021

Conversation

@ptoussai
Copy link
Contributor

@ptoussai ptoussai commented Jan 5, 2021

subtreeCallback was wrongly identified.

@ptoussai
Fix recomputeTree example in README.md
9531568 
`subtreeCallback` was wrongly identified.
@Lodin
Copy link
Owner

Lodin commented Jan 5, 2021

Oh, thanks! Totally missed it.
Could you please fix two more mentions of subtreeWalker in README as well? They are at lines 248 and 282.

@ptoussai
Copy link
Contributor Author

ptoussai commented Jan 5, 2021 •
edited
Loading

EDIT: misread you comment! Please ignore :)

Lodin
Lodin approved these changes Jan 6, 2021
View reviewed changes
Copy link
Owner

@Lodin Lodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lodin Lodin merged commit 7d41f1b into Lodin:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lodin Lodin Lodin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ptoussai @Lodin