Fix Async Tree not keeping descendant nodes hidden #54
Conversation
Updated the createBasicRecord to also verify the parent isShown. Before it only checked to see if the parent was open.
There was a problem hiding this comment.
Hi @HeavensRegent, thanks for the contribution! Sorry for the late response, I'm kind of busy in the latest couple of months.
Could you also add tests for the change?
|
I don't quite understand how to replicate the issue on the code side... more like I have no clue. I'm having a hard time making a test that fails on the current code and is being resolved on the proposed change. The 2 main questions I have: I'm not sure how to trigger an async reload and I'm not sure how to access the property isShowing |
|
@Lodin Here is an attempt at updating the tests to verify the code I added. It doesn't work, but it's as far as I could get with my current understanding. https://github.com/HeavensRegent/react-vtree/tree/tests |
There was a problem hiding this comment.
Sorry for the long response, that's really a busy time for me and I'm kinda outside of this project. I'm going to accept this PR without tests for now because the bug needs to be fixed. If you figure out the correct tests, feel free to open a new PR for that.
|
Released in Sorry again for the mess with the bugfix. |
2 participants
Updated the createBasicRecord to also verify the parent isShown. Before it only checked to see if the parent was open.