SSR: Check for existence of window before calling it #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lodin
requested changes
Apr 30, 2021
Owner
Lodin
left a comment
Lodin
left a comment
There was a problem hiding this comment.
Hi @lukasbuenger, thanks for the contribution and sorry to keep you waiting. I have a single change request, and when you add it to your PR, I would be glad to merge it.
only do single existence check Co-authored-by: Vlad Rindevich <vladrin@vaadin.com>
Lodin
reviewed
Jul 10, 2021
|
|
||
| const useIdleCallback = | ||
| 'requestIdleCallback' in window && | ||
| typeof requestIdleCallback !== 'undefined' |
Owner
There was a problem hiding this comment.
You forgot to add && to the condition
Suggested change
| typeof requestIdleCallback !== 'undefined' | |
| typeof requestIdleCallback !== 'undefined' && |
Owner
|
@lukasbuenger, any updates for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a tiny existence check on the global
windowobject before accessing it further. With this small change, this library, inline with its upstream dependency, would be fully SSR-ready.