Skip to content

SSR: Check for existence of window before calling it #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

SSR: Check for existence of window before calling it #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a051a6c
SSR: Check for existence of window before calling it
lukasbuenger Mar 31, 2021
48d63f6
Update src/Tree.tsx
lukasbuenger May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ const generateNewTree = <
let tempRecord: NodeRecord<TNodePublicState> | null = rootRecord;

const useIdleCallback =
'requestIdleCallback' in window &&
typeof requestIdleCallback !== 'undefined'
Copy link
Owner

@Lodin Lodin Jul 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add && to the condition

Suggested change
typeof requestIdleCallback !== 'undefined'
typeof requestIdleCallback !== 'undefined' &&

placeholder !== undefined &&
// If placeholder is set to null and this is the first build, idle callback
// won't be used. It is necessary for trees with async data which can be
Expand Down