Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix issues with large databases #655
I wouldn't recommend using such a large integer. You're just wasting space by adding support for an EXTREMELY rare case. Also, as md-5 has already mentioned, this would require users to either reset or migrate their entire database just for this very very rare case (Possible impossible even?).
Not to mention the current integer type is an INT unsigned, meaning you'd have to exceed 4,294,967,295 - which at that point your database would most likely be too bloated to function properly.
A config option could be used for that. if set to enabled the upgrader would modify the database if it does not yet use bigints (or create it with bigints if it does not exist). If not set it would generate the database using ints and not modify an existing database. I don't see why upgrading the database outside of the plugin would be any faster. you can use the same sql statements in the plugin
But the main concern is that your pr only changes one table and not all of the accesses to the database to use long/bigint instead of int