Plugin repository optimizations #486

Hirogen · 2025-11-11T21:07:47Z

Plugin repository optimizations

Copilot

Pull Request Overview

This pull request implements a comprehensive plugin repository optimization system for LogExpert. The changes introduce plugin manifest support, security validation, permission management, and extensive UI localization to support internationalization.

Key Changes:

Added plugin manifest system with JSON-based metadata for plugins (version requirements, permissions, dependencies)
Implemented security validation framework for plugins including whitelisting, permission checking, and timeout protection
Introduced extensive resource localization across UI components to support multiple languages
Enhanced error handling with specific exception filters throughout the codebase

Reviewed Changes

Copilot reviewed 61 out of 73 changed files in this pull request and generated 53 comments.

Show a summary per file

File	Description
src/docs/examples/plugin-manifest-example.json	Example plugin manifest showing structure for CSV columnizer
src/SftpFileSystemx64/SftpFileSystem.manifest.json	Manifest for SFTP file system plugin with network permissions
src/SftpFileSystemx86/SftpFileSystemx86.csproj	Links to shared manifest file for x86 build
src/PluginRegistry/PluginValidator.cs	New plugin validation system with security checks and manifest loading
src/PluginRegistry/PluginPermissions.cs	Permission management system for plugins with filesystem, network, and config access controls
src/PluginRegistry/PluginManifest.cs	Plugin manifest parsing and version compatibility checking
src/PluginRegistry/PluginRegistry.cs	Enhanced plugin loading with security validation, timeout protection, and statistics tracking
src/Program.cs	Added culture settings, improved exception handling, and platform attributes
src/LogExpert/Config/ConfigManager.cs	Settings file constant, default language support, and improved error handling
src/LogExpert/Classes/LogExpertProxy.cs	Code formatting improvements and platform attributes
src/LogExpert/Classes/LogExpertApplicationContext.cs	Platform attribute additions
src/LogExpert.sln	README.md added to solution items
src/LogExpert.UI/LogExpert.UI.csproj	Removed SubType attribute from EminusConfigDlg
src/LogExpert.UI/Extensions/Utils.cs	Removed extra blank line
src/LogExpert.UI/Extensions/ResourceHelper.cs	New helper for resource-based UI text mapping
src/LogExpert.UI/Extensions/NativeMethods.cs	Improved icon extraction with proper disposal
src/LogExpert.UI/Extensions/LockFinder.cs	Localized error messages and simplified logic
src/LogExpert.UI/Extensions/FormExtensions.cs	New recursive control enumeration helper
src/LogExpert.UI/Extensions/BookmarkExporter.cs	Improved CSV export with better null handling
src/LogExpert.UI/Entities/PaintHelper.cs	Localized column header and improved border sizing
src/LogExpert.UI/Dialogs/SettingsDialog.resx	Removed duplicate metadata entries
src/LogExpert.UI/Dialogs/SettingsDialog.cs	Added language selection, resource loading, and extensive localization
src/LogExpert.UI/Dialogs/SettingsDialog.Designer.cs	Added language combo box and renamed controls for consistency
src/LogExpert.UI/Dialogs/LogTabWindow/*.cs	Extensive localization, resource loading, and control renaming
src/LogExpert.UI/Dialogs/HighlightDialog.cs	Localized messages and improved error handling
src/LogExpert.UI/Dialogs/Eminus/*.cs	Localized UI, improved resource disposal, and constant extraction
src/LogExpert.UI/Dialogs/ChooseIconDlg.cs	Added resource localization
src/LogExpert.UI/Dialogs/BookmarkWindow.cs	Localized UI text and corrected control naming

Files not reviewed (8)

src/LogExpert.Resources/Resources.de.Designer.cs: Language not supported
src/LogExpert.UI/Controls/DateTimeDragControl.Designer.cs: Language not supported
src/LogExpert.UI/Controls/LogWindow/LogWindow.designer.cs: Language not supported
src/LogExpert.UI/Dialogs/BookmarkCommentDlg.Designer.cs: Language not supported
src/LogExpert.UI/Dialogs/BookmarkWindow.Designer.cs: Language not supported
src/LogExpert.UI/Dialogs/ChooseIconDlg.Designer.cs: Language not supported
src/LogExpert.UI/Dialogs/Eminus/EminusConfigDlg.Designer.cs: Language not supported
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.designer.cs: Language not supported

Comments suppressed due to low confidence (2)

src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.cs:1832

This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.cs:2066
This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

src/PluginRegistry/PluginManifest.cs

src/LogExpert.UI/Dialogs/HighlightDialog.cs

src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.cs

src/LogExpert.UI/Controls/LogWindow/LogWindow.cs

src/PluginRegistry/PluginValidator.cs

src/PluginRegistry/PluginRegistry.cs

src/PluginRegistry/PluginValidator.cs

# Conflicts: # src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.designer.cs # src/LogExpert/Config/ConfigManager.cs

Copilot

Pull Request Overview

Copilot reviewed 22 out of 25 changed files in this pull request and generated 23 comments.

Files not reviewed (2)

src/LogExpert.UI/Controls/LogWindow/LogWindow.designer.cs: Language not supported
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.designer.cs: Language not supported

src/PluginRegistry/PluginRegistry.cs

src/PluginRegistry/PluginPermissions.cs

src/PluginRegistry/PluginManifest.cs

src/PluginRegistry/PluginPermissions.cs

src/PluginRegistry/PluginValidator.cs

Copilot

Pull Request Overview

Copilot reviewed 24 out of 28 changed files in this pull request and generated 3 comments.

Files not reviewed (3)

src/LogExpert.Resources/Resources.Designer.cs: Language not supported
src/LogExpert.UI/Controls/LogWindow/LogWindow.designer.cs: Language not supported
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.designer.cs: Language not supported

src/PluginRegistry/PluginManifest.cs

src/PluginRegistry/PluginValidator.cs

src/PluginRegistry/PluginManifest.cs

src/PluginRegistry.Tests/PluginRegistryTests.cs

src/PluginRegistry/PluginErrorMessages.cs

src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.cs

src/PluginRegistry.Tests/PluginCacheTests.cs

src/PluginRegistry.Tests/PluginIntegrationTests.cs

src/PluginRegistry.Tests/PluginHashVerificationTests.cs

src/PluginRegistry.Tests/PluginRegistryTests.cs

…LogExperts/LogExpert into plugin-repository-optimizations

src/PluginRegistry/PluginValidator.cs

src/PluginRegistry/PluginRegistry.cs

…LogExperts/LogExpert into plugin-repository-optimizations

src/LogExpert.Tests/ColumnizerPickerTest.cs

src/PluginRegistry.Tests/PathTraversalProtectionTests.cs

src/PluginRegistry.Tests/PluginHashVerificationTests.cs

src/PluginRegistry/PluginRegistry.cs

src/PluginRegistry.Tests/PluginHashVerificationTests.cs

src/LogExpert.UI/Dialogs/PluginHashDialog.Designer.cs

…LogExperts/LogExpert into plugin-repository-optimizations

src/LogExpert.UI/Dialogs/PluginTrustDialog.Designer.cs

src/LogExpert.UI/Dialogs/PluginTrustDialog.cs

src/PluginHashGenerator.Tool/Program.cs

src/PluginRegistry/AssemblyInspector.cs

src/PluginHashGenerator.Tool/Program.cs

…LogExperts/LogExpert into plugin-repository-optimizations

src/PluginRegistry/DefaultPluginLoader.cs

src/PluginHashGenerator.Tool/Program.cs

src/PluginRegistry/LazyPluginProxy.cs

Copilot

Pull Request Overview

Copilot reviewed 117 out of 122 changed files in this pull request and generated 48 comments.

Files not reviewed (5)

src/LogExpert.Resources/Resources.Designer.cs: Language not supported
src/LogExpert.UI/Controls/LogWindow/LogWindow.designer.cs: Language not supported
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.designer.cs: Language not supported
src/LogExpert.UI/Dialogs/PluginHashDialog.Designer.cs: Language not supported
src/LogExpert.UI/Dialogs/PluginTrustDialog.Designer.cs: Language not supported

Comments suppressed due to low confidence (1)

src/PluginRegistry.Tests/PluginValidatorTests.cs:1

The JSON property name 'logExpertVersion' doesn't match the actual property name 'logExpert' defined in PluginRequirements (line 546 of PluginManifest.cs shows [property: JsonProperty('logExpert')]). This test manifest will fail to deserialize correctly.

src/docs/PLUGIN_HASH_MANAGEMENT.md

src/docs/PLUGIN_DEVELOPMENT_GUIDE.md

src/RegexColumnizer/RegexColumnizer.cs

src/PluginRegistry/PluginValidator.cs

src/PluginRegistry/PluginManifest.cs

src/PluginRegistry.Tests/PluginManifestTests.cs

src/PluginRegistry.Tests/PluginPermissionManagerTests.cs

src/PluginRegistry.Tests/PluginRegistryTests.cs

src/PluginRegistry.Tests/PluginValidatorTests.cs

src/PluginRegistry.Tests/PluginRegistryTests.cs

…LogExperts/LogExpert into plugin-repository-optimizations

src/PluginRegistry/LazyPluginProxy.cs

+        catch
+        {
+            return false;
+        }


src/PluginRegistry/PluginEventBus.cs

+            catch (Exception ex)
+            {
+                _logger.Error(ex, "Error handling event '{Event}' in plugin '{Plugin}'", eventType.Name, subscription.PluginName);
+            }


initial commit

d5ccff3

Hirogen requested a review from Copilot November 11, 2025 21:08

Copilot started reviewing on behalf of Hirogen November 11, 2025 21:08 View session

Copilot finished reviewing on behalf of Hirogen November 11, 2025 21:09

Copilot AI reviewed Nov 11, 2025

View reviewed changes

Hirogen and others added 3 commits November 13, 2025 20:34

Merge branch 'Development' into plugin-repository-optimizations

00bdf86

# Conflicts: # src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.designer.cs # src/LogExpert/Config/ConfigManager.cs

merge error

23e7f2d

review comments

52d49d8

Hirogen requested a review from Copilot November 14, 2025 12:53

Copilot started reviewing on behalf of Hirogen November 14, 2025 12:54 View session

Copilot finished reviewing on behalf of Hirogen November 14, 2025 12:56

Copilot AI reviewed Nov 14, 2025

View reviewed changes

review comments

987ea8d

Hirogen requested a review from Copilot November 14, 2025 21:23

Copilot started reviewing on behalf of Hirogen November 14, 2025 21:24 View session

Copilot finished reviewing on behalf of Hirogen November 14, 2025 21:25

Copilot AI reviewed Nov 14, 2025

View reviewed changes

src/PluginRegistry/PluginManifest.cs Outdated Show resolved Hide resolved

src/PluginRegistry/PluginValidator.cs Show resolved Hide resolved

src/PluginRegistry/PluginManifest.cs Show resolved Hide resolved

Hirogen and others added 9 commits November 17, 2025 21:02

hashes for plugins

2142ef9

update plugins

ffdf6c9

a few more updates

07de0b0

unit test fix

1c2e911

update plugins

65efe7d

update readme

c09a552

unittests

8add42d

even more tests

1a25392

small fix

3ede763

github-code-quality bot found potential problems Nov 19, 2025

View reviewed changes

Hirogen added 3 commits November 19, 2025 18:36

Merge branch 'plugin-repository-optimizations' of https://github.com/…

2c3dc97

…LogExperts/LogExpert into plugin-repository-optimizations

update more changes

271c8e2

update yml

8d8c565

code quality fixes

34951a9

github-code-quality bot found potential problems Nov 19, 2025

View reviewed changes

src/PluginRegistry/PluginValidator.cs Fixed Show fixed Hide fixed

src/PluginRegistry/PluginValidator.cs Fixed Show fixed Hide fixed

src/PluginRegistry/PluginValidator.cs Fixed Show fixed Hide fixed

src/PluginRegistry/PluginRegistry.cs Fixed Show fixed Hide fixed

Hirogen and others added 5 commits November 19, 2025 21:36

github action -.-

0d1c1f1

chore: update plugin hashes [skip ci]

85c96c5

path.join

9ba5504

Merge branch 'plugin-repository-optimizations' of https://github.com/…

a16e7f3

…LogExperts/LogExpert into plugin-repository-optimizations

chore: update plugin hashes [skip ci]

1e7d9ab

github-code-quality bot found potential problems Nov 19, 2025

View reviewed changes

Hirogen and others added 5 commits November 19, 2025 22:09

unit tests fix

caa7d9c

Merge branch 'plugin-repository-optimizations' of https://github.com/…

27f5800

…LogExperts/LogExpert into plugin-repository-optimizations

chore: update plugin hashes [skip ci]

157820a

unit test fixes and code quality

2e498ec

chore: update plugin hashes [skip ci]

e78a54f

github-code-quality bot found potential problems Nov 20, 2025

View reviewed changes

BRUNER Patrick and others added 3 commits November 20, 2025 12:47

review fixes

fda25ae

Merge branch 'plugin-repository-optimizations' of https://github.com/…

c15919c

…LogExperts/LogExpert into plugin-repository-optimizations

chore: update plugin hashes [skip ci]

12f1f11

github-code-quality bot found potential problems Nov 20, 2025

View reviewed changes

src/PluginRegistry/DefaultPluginLoader.cs Dismissed Show dismissed Hide dismissed

src/PluginHashGenerator.Tool/Program.cs Dismissed Show dismissed Hide dismissed

src/PluginRegistry/LazyPluginProxy.cs Dismissed Show dismissed Hide dismissed

Hirogen requested a review from Copilot November 20, 2025 13:30

Copilot started reviewing on behalf of Hirogen November 20, 2025 13:30 View session

Copilot finished reviewing on behalf of Hirogen November 20, 2025 13:31

Copilot AI reviewed Nov 20, 2025

View reviewed changes

BRUNER Patrick and others added 3 commits November 20, 2025 15:31

small things

4aac8c8

Merge branch 'plugin-repository-optimizations' of https://github.com/…

588daff

…LogExperts/LogExpert into plugin-repository-optimizations

chore: update plugin hashes [skip ci]

2ba52b8

github-code-quality bot found potential problems Nov 20, 2025

View reviewed changes

Hirogen merged commit 73c1ff6 into Development Nov 20, 2025
1 check passed

Hirogen deleted the plugin-repository-optimizations branch November 20, 2025 20:26

This was linked to issues Nov 24, 2025

Default Columnizer is sometimes not loaded correctly #242

Open

NullReferenceException when loading a new log file without persistence data #493

Open

Plugin repository optimizations #486

Plugin repository optimizations #486

Uh oh!

Conversation

Hirogen commented Nov 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!