Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add metadata to create .cab files for the LVFS #3

Merged
merged 1 commit into from May 8, 2017

Conversation

Projects
None yet
2 participants
Contributor

hughsie commented May 3, 2017

This will create files of the format Logitech-Unifying-RQR024.005_B00029.cab

Signed-off-by: Richard Hughes richard@hughsie.com

+ <developer_name>Logitech</developer_name>
+ <releases>
+ <release urgency="high" version="RQR12.07_B0029" date="2017-05-02">
+ <checksum filename="RQR12.07_B0029.hex" target="content"/>
@ogay

ogay May 5, 2017

Member

RQR12.05_B0028 ?

@hughsie

hughsie May 5, 2017

Contributor

Good catch, will respin now.

Member

ogay commented May 8, 2017

We discussed it and we would prefer if every Makefile and xml file comes in its own folder, called 'lvfs', e.g.,

RQR12/RQR12.07/RQR12.07_B0029.hex
RQR12/RQR12.07/RQR12.07_B0029.txt
RQR12/RQR12.07/lvfs/com.logitech.Unifying.RQR12.metainfo.xml
RQR12/RQR12.07/lvfs/Makefile

and the Makefile would create the .cab in the same level as the level of the Makefile: i.e.,
RQR12/RQR12.07/lvfs/Logitech-Unifying-RQR12.07_B0029.cab

Contributor

hughsie commented May 8, 2017

As you wish; one sec.

Sorry I didn't catch this during the last review.

The cab filenames have an inconsistent format; the RQR12 are the correct one.

It also appears in the commit message:
Logitech-Unifying-RQR024.005_B00029.cab should be Logitech-Unifying-RQR24.05_B0029.cab (three extra 0s)

RQR24/RQR24.03/lvfs/Makefile
+
+VENDOR=Logitech
+PROJECT_NAME=Unifying
+VERSION=RQR024.003_B00027
@ogay

ogay May 8, 2017

Member

VERSION=RQR24.03_B0027
(there were three extra 0s)

RQR24/RQR24.05/lvfs/Makefile
+
+VENDOR=Logitech
+PROJECT_NAME=Unifying
+VERSION=RQR024.005_B00029
@ogay

ogay May 8, 2017

Member

VERSION=RQR24.05_B0029
(there were three extra 0s)

Add metadata to create .cab files for the LVFS
This will create files of the format Logitech-Unifying-RQR24.05_B0029.cab

Signed-off-by: Richard Hughes <richard@hughsie.com>
Contributor

hughsie commented May 8, 2017

My error entirely, sorry. New version pushed.

@ogay ogay merged commit dc23f92 into Logitech:master May 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment