Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"virtual" is a mysql keyword but is used as a field in the tracks table #197

Open
bkcabral opened this issue Feb 21, 2018 · 5 comments

Comments

@bkcabral
Copy link

commented Feb 21, 2018

The use of "virtual" as a key word in newer mysql db means it can't be a field in a table. Unfortunately, it is used as such in the tracks table.

@bkcabral bkcabral changed the title "virtual" is a mysql keyword but is used as a fields in the tracks table "virtual" is a mysql keyword but is used as a field in the tracks table Feb 21, 2018
@mherger

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2018

It's probably time to let go and just live with SQLite ;-).

What's the reason to stick with MySQL for LMS?

@bkcabral

This comment has been minimized.

Copy link
Author

commented Feb 21, 2018

The only arguments in the other direction is you want multiple music servers serving off a NAS + shared DB. I don't have a need for that - and I assume most folks don't - but right now it's just broken. So it should either be removed or fixed - no?

@bkcabral bkcabral closed this Feb 21, 2018
@bkcabral bkcabral reopened this Feb 21, 2018
@bkcabral

This comment has been minimized.

Copy link
Author

commented Feb 21, 2018

Didn't mean to close it... ;-)

@mherger

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

That's correct: fix or remove. Would you happen to know in which version MySQL introduced the new keyword?

The fix might be as simple as search/replace virtual with something else (there aren't too many occurrences in our code), plus a schema migration. It's just not something I'd put high on my priority list...

@bkcabral

This comment has been minimized.

Copy link
Author

commented Feb 22, 2018

I'm not sure when it was introduced but it's there in 5.7 FWIW - using the word "virtual" feels dangerous because it's too general and often "overloaded." So it should probably be changed. Now, I looked to see if was an "easy" search-and-replace and it's not - but I'm not sure how queries get formed - e.g. from hash key names in perl such that the scheme is implied in the hash keys. Or I would just push a fix ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.