New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved client to separate file, and added client cjs module build. #1

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@moisadoru
Copy link

moisadoru commented Dec 11, 2018

Contents:

  • extracted client to separate module.
  • added client cjs module build.
  • some unused dependencies cleanup (package forever was not used)
  • documentation updates.
  • renamed LICENCE to LICENSE (see https://help.github.com/articles/licensing-a-repository/)
  • removed .npmignore in favour of package.files
  • added clean npm script.

See #2 issue.

@joelwkall joelwkall changed the base branch from master to move-client-to-separate-file-by-moisadoru Dec 12, 2018

@joelwkall

This comment has been minimized.

Copy link
Member

joelwkall commented Dec 12, 2018

Mostly approved, but will make some minor changes before we add it to our internal repo. Our publisher will then squash merge it to master.

@joelwkall joelwkall merged commit 75e28cb into LoopFiftyFour:move-client-to-separate-file-by-moisadoru Dec 12, 2018

@joelwkall

This comment has been minimized.

Copy link
Member

joelwkall commented Dec 12, 2018

This is now merged to master as well (although it doesn't show in GitHub since we squash merge from our internal repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment