Set carb cache length to 24 hours. #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have run for 2 days with the PR 1234 (24 hours carb store) added to PR 1219 (automated-bolus branch). I believe that I am getting prompt bolus suggestions now when phone has been locked and I wake it up and enter carbs right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigations into delayed display and dosing availability have shown significant cache misses in CarbStore, which results in a HealthKit query. When the phone has been locked for a significant amount of time, HealthKit queries can perform very slowly, as HealthKit is processing journaled data and doing other housekeeping. This fix increases the cache length to a longer value that should eliminate most cache misses.