Red loop retry should refresh device data #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2020
Closed
dthornley
added a commit
to dthornley/Loop
that referenced
this pull request
Nov 20, 2021
* dev-bubble: Clear DEVELOPMENT_TEAM in project file Bump version for release, update cartfile revs Fix CI build Fix carb date picker Bump version for release Carthage build fix for Xcode 12.0.1 Bump carthage revs Red loop retry should refresh device data (LoopKit#1381) Update travis config to build with Xcode 12 Carthage fixes for building with Xcode12 Bump version Carthage fixes for building with Xcode12 Fix release version Release 2.2.1 (LoopKit#1354) # Conflicts: # Cartfile.resolved # Learn/Info.plist # Loop Status Extension/Info.plist # Loop/Info.plist # WatchApp Extension/Info.plist # WatchApp/Info.plist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Loop is failing to loop and displays a red or yellow loop, the user can tap on the red loop and see the last error, and have an option to Retry. The Retry option was just trying to loop again, without triggering a device data refresh. This changes the retry button to attempt to refresh pump and CGM data, so if any comms issues have been resolved by the user (bringing the RL/phone back in range, etc), but Loop hasn't tried comms with the devices, this will trigger a check, and will let the user resume automatic dosing more quickly.