Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 12h or 24h time on chart x-axis depending on locale #952

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
3 participants
@ps2
Copy link
Collaborator

commented May 11, 2019

Updated version of #919. Thanks @reelman!

@reelman

This comment has been minimized.

Copy link

commented May 11, 2019

Thank you for doing it in right way 🙂👍

@eszcloud

This comment has been minimized.

Copy link

commented May 11, 2019

Does "Show 12h or 24h time on chart x-axis depending on locale" mean that the x-axis format will change if we travel to a new locale (e.g. US to Europe) and update the timezone to a local one?

@ps2

This comment has been minimized.

Copy link
Collaborator Author

commented May 11, 2019

No, only if you change your time format in settings or change the language (locale) on your phone.

@eszcloud

This comment has been minimized.

Copy link

commented May 11, 2019

Got it. Thanks!

@ps2 ps2 merged commit 3abfc9f into dev May 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ps2 ps2 deleted the non-english-chart-times branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.