Hebao v2: fix potential duplicate guardian bug #2463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
添加了一个测试，addGuardian函数本身是有去重功能的，如果newGuardians数组中有重复的地址，会调用多次addGuardian函数，但并不会导致钱包出现重复的guardian。 |
kongliangzhong
added a commit
that referenced
this pull request
Jun 7, 2021
* [hebaov2] add a new recover function which can reset guardians * update * add unit test * feedback * update * update * add test for duplicated guardians * Hebao v2: fix potential duplicate guardian bug (#2463) * fix tests Co-authored-by: Daniel Wang <daniel@loopring.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
需要为setInitialGuardians和recover增加测试或者修改测试
@kongliangzhong