Remove Halo.pl! #2

Merged
merged 34 commits into from Oct 24, 2014

Conversation

Projects
None yet
1 participant
@Lordnibbler
Owner

Lordnibbler commented Aug 18, 2014

  • update documentation to inform how to set up systemctl to start this service at boot and configure uart
  • use json instead of 000,000,000,000\n
  • tests
  • fixup! commit this abomination of a PR
  • remove halo.pl
  • remove serialport from package.json, and node_serialport.js
  • refactor server to use properties instead of globals for buffer, etc
  • remove unnecessary logging or change production logging level

@Lordnibbler Lordnibbler self-assigned this Oct 21, 2014

@Lordnibbler

This comment has been minimized.

Show comment
Hide comment
@Lordnibbler

Lordnibbler Oct 22, 2014

Owner

Change of approach with timer to @timer in 44156af fixes light flicker because only one @timer can now exist in memory. still a bug exists because socket.on 'disconnect', => @_disconnected does not actually invoke @_disconnected, @_disconnected() does!

Owner

Lordnibbler commented Oct 22, 2014

Change of approach with timer to @timer in 44156af fixes light flicker because only one @timer can now exist in memory. still a bug exists because socket.on 'disconnect', => @_disconnected does not actually invoke @_disconnected, @_disconnected() does!

Lordnibbler added some commits Oct 23, 2014

Actually invoke disconnected callback
- cleanup dead code comment
- only clear timer if timer is defined

Lordnibbler added a commit that referenced this pull request Oct 24, 2014

@Lordnibbler Lordnibbler merged commit b6361c4 into master Oct 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@Lordnibbler Lordnibbler deleted the halo branch Oct 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment