Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove! #2

merged 34 commits into from Oct 24, 2014

Remove! #2

merged 34 commits into from Oct 24, 2014


Copy link

@Lordnibbler Lordnibbler commented Aug 18, 2014

  • update documentation to inform how to set up systemctl to start this service at boot and configure uart
  • use json instead of 000,000,000,000\n
  • tests
  • fixup! commit this abomination of a PR
  • remove
  • remove serialport from package.json, and node_serialport.js
  • refactor server to use properties instead of globals for buffer, etc
  • remove unnecessary logging or change production logging level
@Lordnibbler Lordnibbler force-pushed the halo branch 8 times, most recently from e9361c1 to dffff3e Aug 21, 2014
@Lordnibbler Lordnibbler force-pushed the halo branch 2 times, most recently from d191879 to 475612d Aug 21, 2014
@Lordnibbler Lordnibbler force-pushed the halo branch 7 times, most recently from 364b561 to c6c837a Aug 22, 2014
Lordnibbler added 2 commits Aug 23, 2014
Copy link
Owner Author

@Lordnibbler Lordnibbler commented Oct 22, 2014

Change of approach with timer to @timer in 44156af fixes light flicker because only one @timer can now exist in memory. still a bug exists because socket.on 'disconnect', => @_disconnected does not actually invoke @_disconnected, @_disconnected() does!

Lordnibbler added 2 commits Oct 23, 2014
- cleanup dead code comment
- only clear timer if timer is defined
Lordnibbler added a commit that referenced this pull request Oct 24, 2014
@Lordnibbler Lordnibbler merged commit b6361c4 into master Oct 24, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
@Lordnibbler Lordnibbler deleted the halo branch Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.