Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite #19

Merged
merged 65 commits into from Jun 28, 2014
Merged

Test suite #19

merged 65 commits into from Jun 28, 2014

Conversation

@Lordnibbler
Copy link
Owner

@Lordnibbler Lordnibbler commented Jun 11, 2014

  • setup karma + mocha + travis
  • server side tests
  • client side tests
    • models
    • collections
    • router
    • views
  • grunt adjustments - JS is borking on heroku/production
  • remove yeoman generated CSS/SASS and exchange with our CSS (now with SASS)
  • revisit pending client side tests
Lordnibbler added 17 commits Jun 8, 2014
- using bower for frontend package management
- using grunt for deploy/asset stuffs
- using handlebars + express to render the backbone app
- grunt build task is borking
- need to remove ($ fn) surrounding all backbone files in order to start
  testing
- see
  http://stackoverflow.com/questions/10371539/why-define-anonymous-function-and-pass-it-jquery-as-the-argument
- update app.js SwatchAppView to be a revealing module, returning an
  init() method
- update main.js to invoke the SwatchAppView's init() method to start
  the backbone app

Use revealing module pattern for backbone app
- update backbone and underscore to latest
- update router.js to account for case when params is undefined
- update karma config and view layout to reference new backbone and
  underscore locations
- add colors_spec tests for some methods
@Lordnibbler Lordnibbler self-assigned this Jun 23, 2014
Lordnibbler added a commit that referenced this issue Jun 28, 2014
@Lordnibbler Lordnibbler merged commit 50e40f1 into master Jun 28, 2014
1 check passed
@Lordnibbler Lordnibbler deleted the enhancement/11 branch Jun 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant