Test suite #19

Merged
merged 65 commits into from Jun 28, 2014

Conversation

Projects
None yet
1 participant
@Lordnibbler
Owner

Lordnibbler commented Jun 11, 2014

  • setup karma + mocha + travis
  • server side tests
  • client side tests
    • models
    • collections
    • router
    • views
  • grunt adjustments - JS is borking on heroku/production
  • remove yeoman generated CSS/SASS and exchange with our CSS (now with SASS)
  • revisit pending client side tests

Lordnibbler added some commits Jun 8, 2014

Yeoman generated node-express template!
- using bower for frontend package management
- using grunt for deploy/asset stuffs
- using handlebars + express to render the backbone app
Combine js compilation into one file
- grunt build task is borking
Add karma
- need to remove ($ fn) surrounding all backbone files in order to start
  testing
- see
  http://stackoverflow.com/questions/10371539/why-define-anonymous-function-and-pass-it-jquery-as-the-argument
Use "revealing module" design pattern
- update app.js SwatchAppView to be a revealing module, returning an
  init() method
- update main.js to invoke the SwatchAppView's init() method to start
  the backbone app

Use revealing module pattern for backbone app
Refactor colors collection to be simpler
- update backbone and underscore to latest
- update router.js to account for case when params is undefined
- update karma config and view layout to reference new backbone and
  underscore locations
- add colors_spec tests for some methods

@Lordnibbler Lordnibbler self-assigned this Jun 23, 2014

Lordnibbler added a commit that referenced this pull request Jun 28, 2014

@Lordnibbler Lordnibbler merged commit 50e40f1 into master Jun 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@Lordnibbler Lordnibbler deleted the enhancement/11 branch Jun 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment