Changed storage backend to local JSON file, refactor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realize I've just entirely rewritten your app :x You may just want me to actually maintain my own fork instead… |
|
Good for me, thank you for this HUGE contribution. |
Lothiraldan
added a commit
that referenced
this pull request
Oct 6, 2012
Changed storage backend to local JSON file, refactor
|
Just see that tasks marked as done are just dropped from DB file, could be cool to keep them with done time. |
|
Hmm, I don't have the use case personally but I might be considering readding the feature back :) Expect a new PR for that though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on twitter, I removed the mongo backend to use a JSON file on the local filesystem instead.