Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Item Renders #260

Merged
merged 76 commits into from Feb 4, 2017

Conversation

@Frost2779
Copy link
Contributor

commented Feb 2, 2017

I fixed the item renders so that items are held like how vanilla items are, instead of them being held flat against your face. Also removed the bits of code that dealt with the rotation of the in first and third person as they weren't really needed in my opinion.

Sam Bassett and others added 30 commits Jan 17, 2017
Sam Bassett
Merge pull request #241 from PrinceOfAmber/featureCreep
release 1.9.17: rod of elevation
Sam Bassett
Merge pull request #258 from PrinceOfAmber/devgoback
Develop build 1.10.1  -   #248 and #156 new error codes for uncrafting.
Sam Bassett
Merge pull request #257 from PrinceOfAmber/develop
Develop release with remote lever
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary cod
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held)
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
Fixed item render
Fixed item to be rendered correctly in hand(To match with how vanilla items are held) and removed unnecessary code
@Lothrazar

This comment has been minimized.

Copy link
Owner

commented Feb 3, 2017

Thanks for cleaning this up! i dont know why i started having those in there, i must have had it from some tutorial maybe and just copy pasted. Eventually i learned about json inheritance but never looked back i guess.

❤️

Ill merge it into the next build so probably tonight or tomorrow, so version 1.10.3 i think it will be

@Frost2779

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2017

Yea no problem, it could still be made better(Maybe i don't actually know. I'm still a newb at modding) but in my own mod I figured out how to fix it and I just wanted to pass it along. Though I might have missed a couple of items, so apologies in advance in case I did.

@Lothrazar Lothrazar changed the base branch from master to develop Feb 4, 2017

@Lothrazar Lothrazar merged commit 00d97e4 into Lothrazar:develop Feb 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.