Skip to content

Run npm on GitHub so it is deployed into the Cloud site #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

Run npm on GitHub so it is deployed into the Cloud site #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ on:
workflow_dispatch: # Allow manual triggering of the workflow

jobs:

# Intentionally NOT syncing from Cloud as all patches/updates etc being done manually on GitHub repo

# Package and Deploy to Umbraco Cloud (without saving the artifact as contains sensitive data)
cloud-deployment:
name: "Deploy to Cloud"
Expand All @@ -23,4 +20,5 @@ jobs:
formsLicenseKey: ${{ secrets.FORMS_LICENSE_KEY }}
with:
pathToWebsite: "src/OpenSourceTest.Site"
csprojFile: "OpenSourceTest.Site.csproj"
csprojFile: "OpenSourceTest.Site.csproj"
pathToFrontendClient: "src/OpenSourceTest.MyExtension/Client"
17 changes: 17 additions & 0 deletions .github/workflows/package-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
csprojFile:
required: true
type: string
pathToFrontendClient:
required: true
type: string

secrets:
projectId:
Expand Down Expand Up @@ -74,6 +77,20 @@ jobs:
run: cp cloud.gitignore .gitignore
shell: bash

# Setup Node.js for frontend build
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22.x'
cache: 'npm'
cache-dependency-path: '${{ inputs.pathToFrontendClient }}/package-lock.json'

# build the frontend assets
- name: Build frontend assets
working-directory: ${{ inputs.pathToFrontendClient }}
run: npm ci && npm run build --if-present
shell: bash

# zip everything, except what is defined in the 'cloud.zipignore'
- name: Zip Source Code
run: zip -r sources.zip . -x@cloud.zipignore
Expand Down
13 changes: 10 additions & 3 deletions src/OpenSourceTest.MyExtension/OpenSourceTest.MyExtension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,20 @@
<Folder Include="wwwroot\" />
</ItemGroup>

<!-- Restore and build Client files -->
<Target Name="RestoreClient" Inputs="Client\package.json;Client\package-lock.json" Outputs="Client\node_modules\.package-lock.json">
<!-- Restore and build Client files outside of Cloud environments -->
<Target Name="RestoreClient"
Inputs="Client\package.json;Client\package-lock.json"
Outputs="Client\node_modules\.package-lock.json">
<Message Importance="high" Text="Restoring Client NPM packages..." />
<Exec Command="npm i" WorkingDirectory="Client" />
</Target>

<Target Name="BuildClient" BeforeTargets="AssignTargetPaths" DependsOnTargets="RestoreClient" Inputs="@(ClientAssetsInputs)" Outputs="$(IntermediateOutputPath)client.complete.txt">
<Target Name="BuildClient"
BeforeTargets="AssignTargetPaths"
DependsOnTargets="RestoreClient"
Inputs="@(ClientAssetsInputs)"
Outputs="$(IntermediateOutputPath)client.complete.txt"
Condition="!('$(UMBRACO__CLOUD__ISRUNNINGONCLOUD)' == 'true' OR '$(ENVIRONMENT__PROJECTID)' != '')">
<Message Importance="high" Text="Executing Client NPM build script..." />
<Exec Command="npm run build" WorkingDirectory="Client" />
<ItemGroup>
Expand Down