From c2093fc819bb1efd96badbfec16816f90cdc7d07 Mon Sep 17 00:00:00 2001 From: beeth0ven Date: Thu, 21 Jul 2022 10:45:57 +0800 Subject: [PATCH 1/2] rename `children` to `states` --- lib/src/observables/states/states.dart | 4 ++-- test/observables/states/states_combine_test.g.dart | 8 ++++---- test/test_gen/combine_test/shared/codes.dart | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/src/observables/states/states.dart b/lib/src/observables/states/states.dart index ee3289a..3b25883 100644 --- a/lib/src/observables/states/states.dart +++ b/lib/src/observables/states/states.dart @@ -15,10 +15,10 @@ class States { ): this.from(Observable(observe)); static States combine({ - required List> children, + required List> states, required R Function(List items) combiner, }) => Observable.combine( - observables: children + observables: states .map((states) => states.observable) .toList(), combiner: combiner, diff --git a/test/observables/states/states_combine_test.g.dart b/test/observables/states/states_combine_test.g.dart index 85f7fbc..9d15712 100644 --- a/test/observables/states/states_combine_test.g.dart +++ b/test/observables/states/states_combine_test.g.dart @@ -19,7 +19,7 @@ void _main() { }); final combine = States.combine( - children: [ + states: [ states1, states2, ], @@ -119,7 +119,7 @@ void _main() { }); final combine = States.combine( - children: [ + states: [ states1, states2, ], @@ -233,7 +233,7 @@ void _main() { }); final combine = States.combine( - children: [ + states: [ states1, states2, ], @@ -334,7 +334,7 @@ void _main() { }); final combine = States.combine( - children: [ + states: [ states1, states2, ], diff --git a/test/test_gen/combine_test/shared/codes.dart b/test/test_gen/combine_test/shared/codes.dart index f99c164..ccb3b40 100644 --- a/test/test_gen/combine_test/shared/codes.dart +++ b/test/test_gen/combine_test/shared/codes.dart @@ -64,7 +64,7 @@ String statesCombine(int? number) { String _combine(bool isObservable, int? number) { final type = isObservable ? 'Observable' : 'States'; final name = isObservable ? 'observable' : 'states'; - final sources = isObservable ? 'observables' : 'children'; + final sources = isObservable ? 'observables' : 'states'; final source = isObservable ? 'observable' : 'child'; if (number == null) { return ''' From a0bcce1af3644e6454adead0ca35ea17656375b5 Mon Sep 17 00:00:00 2001 From: beeth0ven Date: Thu, 21 Jul 2022 10:48:48 +0800 Subject: [PATCH 2/2] rename `child` to `states` --- lib/src/observables/states/states.dart | 22 +++++----- .../observables/states/states_activated.dart | 10 ++--- .../states/states_combine_test.g.dart | 40 +++++++++---------- test/test_gen/combine_test/shared/codes.dart | 2 +- 4 files changed, 37 insertions(+), 37 deletions(-) diff --git a/lib/src/observables/states/states.dart b/lib/src/observables/states/states.dart index 3b25883..c179e62 100644 --- a/lib/src/observables/states/states.dart +++ b/lib/src/observables/states/states.dart @@ -25,24 +25,24 @@ class States { ).asStates(); static States combine2({ - required States child1, - required States child2, + required States states1, + required States states2, required R Function(T1, T2) combiner, }) => Observable.combine2( - observable1: child1.observable, - observable2: child2.observable, + observable1: states1.observable, + observable2: states2.observable, combiner: combiner, ).asStates(); static States combine3({ - required States child1, - required States child2, - required States child3, + required States states1, + required States states2, + required States states3, required R Function(T1, T2, T3) combiner, }) => Observable.combine3( - observable1: child1.observable, - observable2: child2.observable, - observable3: child3.observable, + observable1: states1.observable, + observable2: states2.observable, + observable3: states3.observable, combiner: combiner, ).asStates(); @@ -109,7 +109,7 @@ extension StatesX on States { StatesActivated activated() { return StatesActivated( - child: this + states: this ); } } diff --git a/lib/src/observables/states/states_activated.dart b/lib/src/observables/states/states_activated.dart index 3303a90..5ed9fe5 100644 --- a/lib/src/observables/states/states_activated.dart +++ b/lib/src/observables/states/states_activated.dart @@ -13,19 +13,19 @@ abstract class HasStates { abstract class StatesActivated implements HasStates, Disposable { @internal factory StatesActivated({ - required States child + required States states }) = _StatesActivated; } class _StatesActivated implements StatesActivated { _StatesActivated({ - required States child - }): _child = child { + required States states + }): _states = states { _startObserve(); } - final States _child; + final States _states; final _subject = ReplaySubject(bufferSize: 1); @override @@ -34,7 +34,7 @@ class _StatesActivated implements StatesActivated { late final Disposable _observation; void _startObserve() { - _observation = _child.observe(_subject.onData); + _observation = _states.observe(_subject.onData); } void _stopObserve() { diff --git a/test/observables/states/states_combine_test.g.dart b/test/observables/states/states_combine_test.g.dart index 9d15712..59fb304 100644 --- a/test/observables/states/states_combine_test.g.dart +++ b/test/observables/states/states_combine_test.g.dart @@ -51,8 +51,8 @@ void _main() { }); final combine = States.combine2( - child1: states1, - child2: states2, + states1: states1, + states2: states2, combiner: (it1, it2) => '$it1|$it2', ); @@ -86,9 +86,9 @@ void _main() { }); final combine = States.combine3( - child1: states1, - child2: states2, - child3: states3, + states1: states1, + states2: states2, + states3: states3, combiner: (it1, it2, it3) => '$it1|$it2|$it3', ); @@ -155,8 +155,8 @@ void _main() { }); final combine = States.combine2( - child1: states1, - child2: states2, + states1: states1, + states2: states2, combiner: (it1, it2) => '$it1|$it2', ); @@ -194,9 +194,9 @@ void _main() { }); final combine = States.combine3( - child1: states1, - child2: states2, - child3: states3, + states1: states1, + states2: states2, + states3: states3, combiner: (it1, it2, it3) => '$it1|$it2|$it3', ); @@ -267,8 +267,8 @@ void _main() { }); final combine = States.combine2( - child1: states1, - child2: states2, + states1: states1, + states2: states2, combiner: (it1, it2) => '$it1|$it2', ); @@ -305,9 +305,9 @@ void _main() { }); final combine = States.combine3( - child1: states1, - child2: states2, - child3: states3, + states1: states1, + states2: states2, + states3: states3, combiner: (it1, it2, it3) => '$it1|$it2|$it3', ); @@ -370,8 +370,8 @@ void _main() { }); final combine = States.combine2( - child1: states1, - child2: states2, + states1: states1, + states2: states2, combiner: (it1, it2) => '$it1|$it2', ); @@ -409,9 +409,9 @@ void _main() { }); final combine = States.combine3( - child1: states1, - child2: states2, - child3: states3, + states1: states1, + states2: states2, + states3: states3, combiner: (it1, it2, it3) => '$it1|$it2|$it3', ); diff --git a/test/test_gen/combine_test/shared/codes.dart b/test/test_gen/combine_test/shared/codes.dart index ccb3b40..4cb8bad 100644 --- a/test/test_gen/combine_test/shared/codes.dart +++ b/test/test_gen/combine_test/shared/codes.dart @@ -65,7 +65,7 @@ String _combine(bool isObservable, int? number) { final type = isObservable ? 'Observable' : 'States'; final name = isObservable ? 'observable' : 'states'; final sources = isObservable ? 'observables' : 'states'; - final source = isObservable ? 'observable' : 'child'; + final source = isObservable ? 'observable' : 'states'; if (number == null) { return ''' final combine = $type.combine(