fix: defer Rewind_init until after core initialization to prevent crashes#716
Closed
Helaas wants to merge 0 commit into
Closed
fix: defer Rewind_init until after core initialization to prevent crashes#716Helaas wants to merge 0 commit into
Helaas wants to merge 0 commit into
Conversation
frysee
reviewed
May 12, 2026
| Config_readOptions(); | ||
| applyShaderSettings(); | ||
| Rewind_init(core.serialize_size ? core.serialize_size() : 0); | ||
| rewind_init_ready = 1; |
Member
There was a problem hiding this comment.
Should this take the return value of Rewind_init into account?
Author
There was a problem hiding this comment.
No, because then you wouldn't be able to activate it from the menu if minarch was launched with rewind disabled.
However, Rewind_on_state_change() probably should be. I'll take a look later.
Member
There was a problem hiding this comment.
Does this have to be tested with a specific game or emulator core?
Author
There was a problem hiding this comment.
I tested with a few general ones and then fbneo with the games mentioned in the reddit thread
frysee
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.