Duplicate keys when typing in prompt in Windows Terminal

[jamal]

Did you search for existing issues already? yes

Describe the bug
In Windows Terminal, typing in the prompt dialog enters multiple keys per keypress making it difficult to use the prompt. Tested using PowerShell, Bash (cygwin), and Nushell. Pasting is also a problem and enters more than one key per character.

To Reproduce
Steps to reproduce the behavior

1. Run Slumber in Windows Terminal
2. Select a request that uses a prompt chain
3. Press enter
4. Type a key and notice that it is entered multiple times

Expected behavior
A key should be entered once.

Screenshots

In this screenshot, I typed a once, and then b, and then c (the S is from Win+Shift+S to take a screenshot 😅 )

Version (please complete the following information):

• OS: Windows 10 - 22H2 (Build 19045.4412)
• Terminal: Windows Terminal 1.19.11213.0
• Slumber Version: 1.3.0

Additional context:

Request collection:

chains:
  authorization_code:
    source: !prompt
      message: Authorization Code

requests:
  login: !request
    method: POST
    url: "https://www.example.com"
    headers:
      Accept: application/json
      Content-Type: application/x-www-form-urlencoded
    # authentication: !basic
    #   username: "{{client_id}}"
    #   password: "{{client_secret}}"
    body: |
      grant_type=authorization_code&code={{chains.authorization_code}}

[LucasPickering]

@jamal Thanks for the report. This is a common bug with Ratatui that I thought I handled, but clearly not.

I just pushed up a fix for this, but unfortunately I don't have access to a Windows computer to test it. Do you have cargo installed? If so, would you mind installing my branch to test it out?

cargo install --git https://github.com/LucasPickering/slumber --branch fix-windows-double-type

Note that depending on how you installed Slumber originally, your other version may have priority in your PATH meaning you'll have to execute cargo's version directly to execute it, which should be something like (sorry for my lack of Windows-fu):

~/.cargo/bin/slumber.exe

[jamal]

Sure thing! And, thank you for mentioning Ratatui. I've been quite curious as to what TUI Slumber was using because historically they don't tend to work very well on PowerShell!

[jamal]

OK, I was able to test it and it's indeed fixed! 👏 Thank you for looking at that so quickly.

[LucasPickering]

OK, I was able to test it and it's indeed fixed! 👏 Thank you for looking at that so quickly.

Awesome! One more thing, could you test that holding a key down in the text box repeats it as you would expect? It seems that windows handles the repeating event differently as well.

[jamal]

OK, I was able to test it and it's indeed fixed! 👏 Thank you for looking at that so quickly.

Awesome! One more thing, could you test that holding a key down in the text box repeats it as you would expect? It seems that windows handles the repeating event differently as well.

Yes, it works as expected! That's definitely interesting, but thank you for confirming!