Skip to content

Folia support #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Folia support #3615

wants to merge 1 commit into from

Conversation

lucko
Copy link
Member

@lucko lucko commented Apr 1, 2023

Adds support for Paper's regionised/multithreading Folia project.

As you can see, there were fairly minimal changes required to get LuckPerms working, so I don't expect many bugs/issues. It has been lightly tested by me. :)

Test build

There is a jar you can download from Jenkins: https://ci.lucko.me/job/LuckPerms-Folia/

@lucko

This comment was marked as outdated.

@lucko lucko linked an issue Apr 1, 2023 that may be closed by this pull request
@sowelipililimute
Copy link

Needs rebase, but this seems to work for me on 1.19 Folia

@lucko

This comment was marked as outdated.

@sowelipililimute
Copy link

sowelipililimute commented Jun 25, 2023

bukkit/src/main/java/me/lucko/luckperms/bukkit/messaging/PluginMessageMessenger.java:63 should be updated to Folia; the Folia code would look something like

server.getAsyncScheduler().runAtFixedRate(plugin, task -> {
    Collection<? extends Player> players = PluginMessageMessenger.this.plugin.getBootstrap().getServer().getOnlinePlayers();
    Player p = Iterables.getFirst(players, null);
    if (p == null) {
        return;
    }

    p.sendPluginMessage(PluginMessageMessenger.this.plugin.getLoader(), CHANNEL, buf);
    task.cancel();
}, 20L, 2000L, TimeUnit.MILLISECONDS);


private static boolean isFolia() {
try {
Class.forName("io.papermc.paper.threadedregions.scheduler.RegionScheduler");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Class.forName("io.papermc.paper.threadedregions.scheduler.RegionScheduler");
Class.forName("io.papermc.paper.threadedregions.RegionizedServer");

paper api now includes the folia scheduler stuff

@ghost ghost mentioned this pull request Jun 28, 2023
@ranminecraft
Copy link

merge plz !

@ewof
Copy link

ewof commented Sep 13, 2023

foliabros..

@ewof
Copy link

ewof commented Sep 19, 2023

.

@powercasgamer
Copy link
Contributor

.

don't post useless comments on prs

@DxsSucuk
Copy link

DxsSucuk commented Nov 6, 2023

Anything new about this?

@lucko lucko added the type: new platform The issue is suggesting the implementation of a new platform / platform version. label Nov 6, 2023
@securebread
Copy link

is there a download for 1.20.2?

@SquareCodeFX
Copy link

@lucko how are things going here?

@lucko
Copy link
Member Author

lucko commented Jan 6, 2024

I have rebased this PR and updated to Folia 1.20.2 - builds are available from Jenkins: https://ci.lucko.me/job/LuckPerms-Folia/

@BearLeonLight
Copy link

What's the progress and when will it be merged?
Currently I'm using it normally on 1.20.4.

@iLemon
Copy link

iLemon commented May 23, 2024

pls merge

@RitaSister
Copy link

really, when been is merged?

@underscore11code
Copy link
Member

We appreciate the interest everyone, but comments like "when will this be merged" or "any updates" do nothing but clutter the PR.

When Luck deems the PR ready, it will be merged. Keep in mind there's more thought that goes into adding supporting a new platform than just "does the code work", especially for a bleeding-edge platform like Folia.

If and when there is any updates, they will be posted here, on the Discord, or some combination thereof.

Thank you!

@lucko
Copy link
Member Author

lucko commented Jul 7, 2024

Rebased and updated to 1.20.6

@RitaSister
Copy link

Rebased and updated to 1.20.6

build is failed

@lucko
Copy link
Member Author

lucko commented Jul 7, 2024

Rebased and updated to 1.20.6

build is failed

Thanks, fixed it

@Dovias
Copy link

Dovias commented Jul 7, 2024

Rebased and updated to 1.20.6

Thank you for your efforts on Luckperms plugin, I was planning to maybe give updating to 1.20.6 a try, but you were quicker 🥇 ❤️

@lucko lucko force-pushed the feat/folia branch 3 times, most recently from 2ded127 to 89fbd07 Compare August 16, 2024 11:45
@Aruvelut-123
Copy link

is it support 1.21.1? I need to use it because my server is 1.21.1 folia and no luckperms like plugin for that.

@x1aoren
Copy link

x1aoren commented Aug 24, 2024

它支持 1.21.1 吗?我需要使用它,因为我的服务器是 1.21.1 作品集,没有像插件这样的运气。

完全可以用

@Aruvelut-123
Copy link

它支持 1.21.1 吗?我需要使用它,因为我的服务器是 1.21.1 作品集,没有像插件这样的运气。

完全可以用

好的谢谢

@Panda260
Copy link

Is there a date or time when Folia will be supported in the official version?

@OoLunar
Copy link

OoLunar commented Nov 26, 2024

Bump. Was able to rebase just fine on the latest commit

@Q2297045667
Copy link

is it support 1.21.4? I need it

@x1aoren
Copy link

x1aoren commented Dec 15, 2024

is it support 1.21.4? I need it

你试试,应该可以,我的服务器还没有升级到1.21.4。1.21.2可以使用

@Q2297045667
Copy link

is it support 1.21.4? I need it

你试试,应该可以,我的服务器还没有升级到1.21.4。1.21.2可以使用

看起来运行的还不错,我还没有深入的测试

It looks to be running very well, I haven't conducted in-depth testing yet

@Euphillya
Copy link

On 1.21.3+, context world don't work

@Ownercz
Copy link

Ownercz commented Dec 31, 2024

Hi, any chance for merge?

@kaxonomy
Copy link

Bump, please merge

@BNTFryingPan
Copy link
Member

this pr does not need to be bumped, nor does it need to be merged in order to use luckperms on folia. if you are running a folia server, see the link for test builds in the first post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new platform The issue is suggesting the implementation of a new platform / platform version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will LuckPerm work with Folia?