Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French Language Worker #239

Closed
Adirelle opened this issue Nov 29, 2018 · 7 comments
Closed

French Language Worker #239

Adirelle opened this issue Nov 29, 2018 · 7 comments

Comments

@Adirelle
Copy link
Contributor

Adirelle commented Nov 29, 2018

Hello,

According this post on the forum, I created a gist with the abstract and the french language worker: https://gist.github.com/Adirelle/c9186e8f61776c9ea2b45a64811f14fe

Right now, this is just a copy of the code from the forum but I will update it quite soon to reflect the needed changes. It is easier to follow using a gist since the gist tracks the changes. Note that though I am developer, I never worker with C#, so my changes would be approximative at best.

I have a question for @isonil though: I known some developpers are not comfortable about using regular expressions because of their complexity and/or their performance. What is the stance on the subject for Rimworld (for System.Text.RegularExpressions) ? The functionalities that would ease fixing the Language Worker would be: alternatives, pattern capturing (to be used in replacements) and word boundary detection.

@Adirelle
Copy link
Contributor Author

Je me demande si on ne devrait pas juste inclure le fichier dans le répertoire Notes, même s'il n'est pas utilisé automatiquement, pour garder une trace.

@b606
Copy link
Contributor

b606 commented Nov 30, 2018

J'y ai pensé aussi. Est-ce qu'ils ont répondu ?

@Adirelle
Copy link
Contributor Author

Adirelle commented Dec 1, 2018

Ben non, comme tu vois. :)

@isonil
Copy link
Contributor

isonil commented Dec 6, 2018

@Adirelle Regular expressions are indeed a bit slower but I think it's ok if it's going to make implementing LanguageWorker much easier. Russian LanguageWorker for example uses many regular expressions.

Once you finish working you can let me know so I'll integrate it.

If you have any questions feel free to ask.

@Adirelle
Copy link
Contributor Author

Adirelle commented Dec 9, 2018

For reference, here is my try to correct the PostProcessor: https://dotnetfiddle.net/qInZbi

@kiliak
Copy link
Contributor

kiliak commented Mar 17, 2020

On clos?

@b606
Copy link
Contributor

b606 commented Mar 17, 2020

On peut je pense.

@b606 b606 closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants