Skip to content

Make Makefile more friendly to packaging - #5

Closed
gdsotirov wants to merge 1 commit into
LudovicRousseau:masterfrom
gdsotirov:patch-1
Closed

Make Makefile more friendly to packaging#5
gdsotirov wants to merge 1 commit into
LudovicRousseau:masterfrom
gdsotirov:patch-1

Conversation

@gdsotirov

Copy link
Copy Markdown

Allow additional CFLAGS and have all the installation paths in variables, so easily overrideable from environment (e.g. with make -e).

Allow additional CFLAGS and have all the installation paths in variables, so easily overrideable from environment (e.g. with `make -e`).
@gdsotirov gdsotirov changed the title Make Makefile more package friendly Make Makefile more friendly to packaging Jan 29, 2017
@LudovicRousseau

Copy link
Copy Markdown
Owner

Using CFLAGS="whatever" make should already use your defined value of CFLAGS. No?

Also I would use BINDIR ?= /bin so that it is easy to overwrite it using: BINDIR=foobar make
https://www.gnu.org/software/make/manual/make.html#index-_003f_003d

Comments?

LudovicRousseau added a commit that referenced this pull request Jan 29, 2017
Thanks to Georgi D. Sotirov for the idea
#5
@LudovicRousseau

Copy link
Copy Markdown
Owner

Partly applied in 22b65fe

@gdsotirov

gdsotirov commented Jan 29, 2017

Copy link
Copy Markdown
Author

For the ?= operator no comments at all - it's even better like this. But I used different variable for CFLAGS, because of make -e. I think without it it would be OK, but I'll check it tomorrow and write back.

@gdsotirov

Copy link
Copy Markdown
Author

So now with the ?= operator and without -e flag everything is OK - I'm able to set both CFLAGS and INSTALL_* variables. Thanks for applying the patch. The issue could be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants