Repository navigation
fix ATR parser path detect - #82
Closed
CoelacanthusHex wants to merge 1 commit into
Closed
CoelacanthusHex wants to merge 1 commit into
CoelacanthusHex wants to merge 1 commit into
Conversation
In LudovicRousseau@57f1b8b, LudovicRousseau try to add a option to specify ATR parser command. But in logic of this commit, if no --enable-parser=foobar was specified (i.e. $ATRparser == no), configure.ac will ignore default path which was set in $ATR_PARSER and then lead ATR analyze feature of pcsc_scan to be lost. So I add a new branch: if $ATRparser is no and $ATR_PARSER is not no, it will use $ATR_PARSER. At same time, set ATRparser to ATR_PARSER to ensure stats at the end works correctly. Signed-off-by: Coelacanthus <CoelacanthusHex@gmail.com>
CoelacanthusHex
force-pushed
the
fix/ATRPARSER
branch
from
December 29, 2023 10:57
64c6d24 to
d5d5f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 57f1b8b, LudovicRousseau try to add a option to specify ATR parser command. But in logic of this commit, if no --enable-parser=foobar was specified (i.e. $ATRparser == no), configure.ac will ignore default path which was set in $ATR_PARSER and then lead ATR analyze feature of pcsc_scan to be lost. So I add a new branch: if $ATRparser is no and $ATR_PARSER is not no, it will use $ATR_PARSER. At same time, set ATRparser to ATR_PARSER to ensure stats at the end works correctly.