Skip to content

Cory Benfield
Lukasa

Organizations

@requests @PyconUK @pyca @certifi @hapy @projectcalico @python-hyper
Lukasa commented on issue certifi/python-certifi#22
@Lukasa

What I mean when I say there is no utility is that the code to do this is about 4 lines: just append the certifi PEM bundle to the PKI bundle you a…

Lukasa commented on issue certifi/python-certifi#22
@Lukasa

There's no danger to letting the application do it, but there's not really any utility in providing a function for it either. The user is quite cap…

Lukasa commented on issue certifi/python-certifi#22
@Lukasa

I'm really nervous about the idea of providing some global way to hook into certifi. Generally speaking, I think the better approach is the one I'm…

Lukasa commented on pull request shazow/urllib3#801
@Lukasa

Because they were introduced in #761, which is being reverted here. We could leave the tests in place if you think that's sensible.

@Lukasa
  • @Lukasa f084e84
    Use trust system as a global.
@Lukasa
  • @Lukasa b235529
    Requires not trust_system or Linux.
Lukasa commented on issue kennethreitz/requests#2966
Lukasa opened pull request shazow/urllib3#802
@Lukasa
[WIP] Experimental code for cert validation in OS X and Windows
1 commit with 27 additions and 8 deletions
Lukasa commented on pull request python-hyper/certitude#8
@Lukasa

Note also that this is probably not good enough to be "real" code yet: for one thing, there's not really enough testing I think. However, I think i…

Lukasa opened pull request python-hyper/certitude#8
@Lukasa
Rewrite to have validation code instead.
1 commit with 210 additions and 168 deletions
Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

Ok, a proposed fix is in shazow/urllib3#801.

Lukasa opened pull request shazow/urllib3#801
@Lukasa
Better handle the IPv6 debacle.
8 commits with 11 additions and 90 deletions
Lukasa created branch requests-3002 at Lukasa/urllib3
Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

So @shazow: the problem we have here is that the connection_from_url would not pass the port explicitly. That's avoided with the pool manager (whic…

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

Ok, so the summary here is that the original fix is bad. Rather than removing that strip, we needed to fix connection_from_url. Ok, good, well now …

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

Ah, no, it's all terrible again: urllib3 gets this wrong if you use a poolmanager instead of connection_from_url. So we're back to urllib3 again.

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

AHA! This isn't a urllib3 bug per se, it's a requests bug. That is, the example used in urllib3 in the original bug was fixed, we just do something…

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

httplib/http.client seems to just be making a total hash of this. I don't understand at all. And that causes us a problem, because we can't revert …

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

And in fact my previous example was not good enough. This is what I've found so far: Python 3.4.3 (default, Sep 15 2015, 12:08:21) [GCC 4.2.1 Compa…

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

Ugh, typically while I found that this bug 'fixed' the issue I didn't look any closer than that. It does fix the issue, but in the most naive way p…

@Lukasa
Any idea if it would be possible to use something like oscrypto instead of the bundled SSL lib for HTTPS?
@Lukasa
Requests default to environment CA even when there's a session-set CA
Lukasa commented on issue kennethreitz/requests#2998
@Lukasa

Closing to centralise on #2018.

Lukasa commented on pull request kennethreitz/requests#3003
@Lukasa

@7uice Presumably we could add flags to dump to resolve that problem though? Generally speaking I'm in favour of keeping this kind of code out of r…

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

Yup, so that's why we need an explanation for the logic. I'll fix it up tomorrow if no one beats me to it.

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

So this was probably introduced by shazow/urllib3#708. Looks like we'll have to revert that @shazow. @pneumaticdeath Why Python version are you using?

Lukasa commented on issue kennethreitz/requests#3002
@Lukasa

Just to clarify, where did you install requests from?

@Lukasa
Multipart mixed responses generate warnings
Something went wrong with that request. Please try again.