Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty values for background property #12

Closed
NicolasJEngler opened this issue Jan 1, 2016 · 3 comments
Closed

Empty values for background property #12

NicolasJEngler opened this issue Jan 1, 2016 · 3 comments

Comments

@NicolasJEngler
Copy link

Hi there,

Super thrilled to use these blendmodes. Just one thing I noticed, there are several background properties without a proper value set (see lines 171, 185, 189, 205, 209, 230, 234, and 237 of styles/colofilter.css). This is most likely happening due to the lack of definition for some values in the Sass map of styles/colofilter.scss.

I would gladly create a pull request to mend this, but I'm a little lost on what values should go there.

@LukyVj
Copy link
Owner

LukyVj commented Jan 3, 2016

Hi @NicolasJEngler !

Thanks for opening the issue!
Yeah, you're right, and it's because of the $color-map values for the gradients.

I had to keep them empty. And so, when compiled, it will write them with an empty value.

Thanks for your issue, I'm about to fix that!

@LukyVj LukyVj closed this as completed in 11b93c7 Jan 3, 2016
LukyVj added a commit that referenced this issue Jan 3, 2016
@LukyVj
Copy link
Owner

LukyVj commented Jan 3, 2016

Fixed in 11b93c7

Thank you again!

@NicolasJEngler
Copy link
Author

Don't mention it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants