-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up namespace #49
Conversation
I'm thinking of joining all the three CL related files in |
I am not sure about this... I assume you are proposing to have the 3 classes in one file, right? |
Yep, that is exactly what I was thinking. 3 classes in one file. So we would have files for EL, PL, CL, but subclasses would be in the same. I don't think there will be so many functions that are specific only to SEM or TEM. So far I mostly still have my signals as CLSpectrum. We could also merge them now and if it ever gets too crowded still separate them. Just some ideas, I am not passionate about either solution. |
@jlaehne I agree to go ahead and merge the 3 classes in one file. |
done (I tried to introduce a test for a warning from #44, but that would require the github-actions to include a hyperspy-gui package, so it is commented out for the moment. We can add that in a later PR to improve coverage.) |
Based on the comment from at #17 (comment) I cleaned up the namespace in analogy to pyxem/pyxem#704.
Progress:
Example:
Signals would be initiated as in HyperSpy and pyxem:
s = lum.signals.LumiSpectrum(np.arange(10))