-
Notifications
You must be signed in to change notification settings - Fork 0
Integrate NLG Processing into Report Orchestrator #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA variable holding generated NLG content is renamed from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
backend/app/core/orchestrator.py (1)
110-127: NLG generation and summary wiring look correctThe new
nlg_sectionsflow (generate_nlg_outputs(aggregated_data)→build_final_summary(nlg_sections, scores)) is type‑ and shape‑compatible withReportNLGEngineandReportSummaryEngine, and should produce the expected section‑wise narratives feeding into the final summary. If you want extra clarity later, you could consider aligning naming across modules (e.g., parameter name inbuild_final_summary), but it’s not required functionally.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
backend/app/core/__pycache__/orchestrator.cpython-313.pycis excluded by!**/*.pycbackend/app/services/nlg/__pycache__/__init__.cpython-313.pycis excluded by!**/*.pycbackend/app/services/nlg/__pycache__/prompt_templates.cpython-313.pycis excluded by!**/*.pycbackend/app/services/nlg/__pycache__/report_nlg_engine.cpython-313.pycis excluded by!**/*.pycbackend/app/services/summary/__pycache__/report_summary_engine.cpython-313.pycis excluded by!**/*.pycbackend/logs/app.logis excluded by!**/*.log
📒 Files selected for processing (1)
backend/app/core/orchestrator.py(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
backend/app/core/orchestrator.py (2)
backend/app/services/nlg/report_nlg_engine.py (1)
generate_nlg_outputs(24-72)backend/app/services/summary/report_summary_engine.py (1)
build_final_summary(48-72)
🔇 Additional comments (1)
backend/app/core/orchestrator.py (1)
129-136: No compatibility issues found—persistnlg_sectionsas intended.Verification confirms no downstream code expects a legacy
nlg_outputskey on report objects. The API endpoint/reports/{report_id}/datareturns the full report dict, which will now safely include the newnlg_sectionskey alongsidestatus,data, andscores. Tests and endpoints expect the structure you've implemented.
|
the integration of NLG processing should really streamline the report workflow... merging this! 👍 |
This PR integrates the Natural Language Generation (NLG) engine into the report orchestration flow, ensuring that raw agent data is processed into human-readable text.
Changes
orchestrator.pyto include a new step for NLG processing.nlg_sectionswithin the report storage structure.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.