From 073e2bab374711a5e4b1ce788e7b81e32cd0cba1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonatan=20Ma=CC=88nnchen?= Date: Sat, 5 Mar 2016 17:27:47 +0000 Subject: [PATCH] CodeClimate & ESLint --- .codeclimate.yml | 6 + .eslintrc | 19 + Gulpfile.js | 10 +- angular-hal.js | 431 +++++++++--------- angular-hal.min.js | 12 +- package.json | 3 + src/client/link-header.factory.js | 13 +- .../hal-configuration.provider.js | 10 +- .../response-transformer.service.js | 6 +- src/resource/resource.factory.js | 8 +- test/helpers.js | 2 +- .../halbuilder-test-resources.spec.js | 8 +- 12 files changed, 269 insertions(+), 259 deletions(-) create mode 100644 .codeclimate.yml create mode 100644 .eslintrc diff --git a/.codeclimate.yml b/.codeclimate.yml new file mode 100644 index 0000000..4988fef --- /dev/null +++ b/.codeclimate.yml @@ -0,0 +1,6 @@ +engines: + eslint: + enabled: true +ratings: + paths: + - "src/**/*" diff --git a/.eslintrc b/.eslintrc new file mode 100644 index 0000000..9fe9761 --- /dev/null +++ b/.eslintrc @@ -0,0 +1,19 @@ +{ + "extends": "eslint:recommended", + "globals": { + "angular": false, + "module": false, + "inject": false, + "describe": false, + "beforeEach": false, + "afterEach": false, + "expect": false, + "fail": false, + "it": false, + "require": false, + "toObject": false + }, + "rules":{ + "comma-dangle": [ 0, "always-multiline" ] + } +} diff --git a/Gulpfile.js b/Gulpfile.js index 63ca459..905861c 100644 --- a/Gulpfile.js +++ b/Gulpfile.js @@ -5,7 +5,8 @@ var gulp = require('gulp') , jshint = require('gulp-jshint') , gulpUtil = require('gulp-util') , angularFilesort = require('gulp-angular-filesort') - , karma = require('karma'); + , karma = require('karma') + , eslint = require('gulp-eslint'); gulp.task('default', [ 'compress', @@ -26,6 +27,7 @@ gulp.task('watch', function() { gulp.task('test', [ 'karma', 'jshint', + 'eslint', ]); gulp.task('compress', [ @@ -55,6 +57,12 @@ gulp.task('jshint', function() { .pipe(jshint.reporter('jshint-stylish')); }); +gulp.task('eslint', function() { + return gulp.src([__dirname + '/src/**/*.js', __dirname + '/test/**/*.js']) + .pipe(eslint()) + .pipe(eslint.format()); +}); + gulp.task( 'karma', [ diff --git a/angular-hal.js b/angular-hal.js index 7fde7d0..7e362c3 100644 --- a/angular-hal.js +++ b/angular-hal.js @@ -272,8 +272,7 @@ ); (function( - module, - isArray + module ) { 'use strict'; @@ -454,7 +453,7 @@ * @return {Boolean} */ function $has(rel) { - return $hasLink || $hasEmbedded; + return $hasLink(rel) || $hasEmbedded(rel); } /** @@ -549,8 +548,7 @@ } } })( - angular.module('angular-hal.resource'), - angular.isArray + angular.module('angular-hal.resource') ); (function( @@ -779,214 +777,6 @@ angular.extend ); -(function( - angular -) { - 'use strict'; - - // Add module for client - angular.module('angular-hal.client', [ - 'angular-hal.utility', - ]); - -})( - angular -); - -(function( - module, - merge, - forEach -) { - 'use strict'; - - // Add factory for LinkHeader - module.factory('LinkHeader', LinkHeaderFactory); - - // Inject Dependencies - LinkHeaderFactory.$inject = [ - '$q', - '$extendReadOnly', - '$injector', - '$halConfiguration', - ]; - - /** - * Factory for LinkHeader - * @param {Q} $q - * @param {Function} $extendReadOnly - * @param {Injector} $injector Prevent Circular Dependency by injecting $injector instead of $http - * @param {Object} $halConfiguration - */ - function LinkHeaderFactory($q, $extendReadOnly, $injector, $halConfiguration) { - return LinkHeader; - - /** - * Link Header - * - * @param {String} uriReference The Link Value - * @param {Object} linkParams The Link Params - * @constructor - */ - function LinkHeader(uriReference, linkParams) { - var self = this; - - /** - * Initialize the LinkHeader - * - * @return void - */ - (function init() { - merge(self, { - uriReference: uriReference, - linkParams: angular.merge( - { - rel: null, - anchor: null, - rev: null, - hreflang: null, - media: null, - title: null, - type: null, - }, - linkParams - ), - }); - })(); - - /** - * Convert LinkHeader to String - * - * @return {String} - */ - self.toString = function toString() { - var result = '<' + self.uriReference + '>' - , params = []; - - forEach( - self.linkParams, - function(paramValue, paramName) { - if(paramValue) { - params.push(paramName + '="' + paramValue + '"'); - } - } - ); - - if(params.length < 1) { - return result; - } - - result = result + ';' + params.join(';'); - - return result; - }; - - return this; - } - } -})( - angular.module('angular-hal.client'), - angular.merge, - angular.forEach -); - -(function( - module, - extend, - merge -) { - 'use strict'; - - // Add halCLient service - module.service('halClient', HalClientService); - module.service('$halClient', HalClientService); - - // Inject Dependencies - HalClientService.$inject = [ - '$log', - '$http', - 'LinkHeader', - '$halConfiguration', - ]; - - /** - * @param {Log} $log - * @param {Http} $http - * @param {Function} LinkHeader - * @param {Object} $halConfiguration - * @deprecated The halClient service is deprecated. Please use $http directly instead. - */ - function HalClientService($log, $http, LinkHeader, $halConfiguration) { - var self = this; - - /** - * @return Initialize halClient - */ - (function init() { - extend(self, { - $get: $get, - $post: $post, - $put: $put, - $patch: $patch, - $delete: $delete, - $del: $delete, - $link: $link, - $unlink: $unlink, - LinkHeader: LinkHeader, - }); - })(); - - /* @ngNoInject */ - function $get(href, options) { - return $request('GET', href, options); - } - - function $post(href, options, data) { - return $request('POST', href, options, data); - } - - function $put(href, options, data) { - return $request('PUT', href, options, data); - } - - function $patch(href, options, data) { - return $request('PATCH', href, options, data); - } - - function $delete(href, options) { - return $request('DELETE', href, options); - } - - function $link(href, options, linkHeaders) { - options = options || {}; - options.headers = options.headers || {}; - options.headers.Link = linkHeaders.map(function(link) { return link.toString(); }); - return $request('LINK', href, options); - } - - function $unlink(href, options, linkHeaders) { - options = options || {}; - options.headers = options.headers || {}; - options.headers.Link = linkHeaders.map(function(link) { return link.toString(); }); - return $request('UNLINK', href, options); - } - - function $request(method, href, options, data) { - options = options || {}; - $log.log('The halClient service is deprecated. Please use $http directly instead.'); - return $http(merge(options, { - method: method, - url: $halConfiguration.urlTransformer(href), - data: data, - })); - } - } -})( - angular.module('angular-hal.client'), - angular.extend, - angular.merge -); - (function( angular ) { @@ -1003,8 +793,7 @@ ); (function( - module, - isArray + module ) { 'use strict'; @@ -1031,8 +820,7 @@ } } })( - angular.module('angular-hal.http-interception'), - angular.isArray + angular.module('angular-hal.http-interception') ); (function( @@ -1168,6 +956,11 @@ , forceJSONResource = false , urlTransformer = noopUrlTransformer; + // Inject Dependencies + $get.$inject = [ + '$log', + ]; + return { setLinksAttribute: setLinksAttribute, setEmbeddedAttribute: setEmbeddedAttribute, @@ -1238,11 +1031,6 @@ return url; } - // Inject Dependencies - $get.$inject = [ - '$log', - ]; - /** * @return {Object} */ @@ -1265,6 +1053,205 @@ angular.module('angular-hal.configuration') ); +(function( + angular +) { + 'use strict'; + + // Add module for client + angular.module('angular-hal.client', [ + 'angular-hal.utility', + ]); + +})( + angular +); + +(function( + module, + merge, + forEach +) { + 'use strict'; + + // Add factory for LinkHeader + module.factory('LinkHeader', LinkHeaderFactory); + + // Inject Dependencies + LinkHeaderFactory.$inject = []; + + /** + * Factory for LinkHeader + */ + function LinkHeaderFactory() { + return LinkHeader; + + /** + * Link Header + * + * @param {String} uriReference The Link Value + * @param {Object} linkParams The Link Params + * @constructor + */ + function LinkHeader(uriReference, linkParams) { + var self = this; + + /** + * Initialize the LinkHeader + * + * @return void + */ + (function init() { + merge(self, { + uriReference: uriReference, + linkParams: angular.merge( + { + rel: null, + anchor: null, + rev: null, + hreflang: null, + media: null, + title: null, + type: null, + }, + linkParams + ), + }); + })(); + + /** + * Convert LinkHeader to String + * + * @return {String} + */ + self.toString = function toString() { + var result = '<' + self.uriReference + '>' + , params = []; + + forEach( + self.linkParams, + function(paramValue, paramName) { + if(paramValue) { + params.push(paramName + '="' + paramValue + '"'); + } + } + ); + + if(params.length < 1) { + return result; + } + + result = result + ';' + params.join(';'); + + return result; + }; + + return this; + } + } +})( + angular.module('angular-hal.client'), + angular.merge, + angular.forEach +); + +(function( + module, + extend, + merge +) { + 'use strict'; + + // Add halCLient service + module.service('halClient', HalClientService); + module.service('$halClient', HalClientService); + + // Inject Dependencies + HalClientService.$inject = [ + '$log', + '$http', + 'LinkHeader', + '$halConfiguration', + ]; + + /** + * @param {Log} $log + * @param {Http} $http + * @param {Function} LinkHeader + * @param {Object} $halConfiguration + * @deprecated The halClient service is deprecated. Please use $http directly instead. + */ + function HalClientService($log, $http, LinkHeader, $halConfiguration) { + var self = this; + + /** + * @return Initialize halClient + */ + (function init() { + extend(self, { + $get: $get, + $post: $post, + $put: $put, + $patch: $patch, + $delete: $delete, + $del: $delete, + $link: $link, + $unlink: $unlink, + LinkHeader: LinkHeader, + }); + })(); + + /* @ngNoInject */ + function $get(href, options) { + return $request('GET', href, options); + } + + function $post(href, options, data) { + return $request('POST', href, options, data); + } + + function $put(href, options, data) { + return $request('PUT', href, options, data); + } + + function $patch(href, options, data) { + return $request('PATCH', href, options, data); + } + + function $delete(href, options) { + return $request('DELETE', href, options); + } + + function $link(href, options, linkHeaders) { + options = options || {}; + options.headers = options.headers || {}; + options.headers.Link = linkHeaders.map(function(link) { return link.toString(); }); + return $request('LINK', href, options); + } + + function $unlink(href, options, linkHeaders) { + options = options || {}; + options.headers = options.headers || {}; + options.headers.Link = linkHeaders.map(function(link) { return link.toString(); }); + return $request('UNLINK', href, options); + } + + function $request(method, href, options, data) { + options = options || {}; + $log.log('The halClient service is deprecated. Please use $http directly instead.'); + return $http(merge(options, { + method: method, + url: $halConfiguration.urlTransformer(href), + data: data, + })); + } + } +})( + angular.module('angular-hal.client'), + angular.extend, + angular.merge +); + (function( angular ) { diff --git a/angular-hal.min.js b/angular-hal.min.js index 85922fb..2d85059 100644 --- a/angular-hal.min.js +++ b/angular-hal.min.js @@ -6,15 +6,15 @@ !function(a){"use strict";a.module("angular-hal.url-generator",[])}(angular); !function(r){"use strict";function n(r){function n(){if("undefined"!=typeof r.rfc6570)return r.rfc6570;if(!t&&"undefined"!=typeof require)return require("rfc6570/src/main");throw new Error("Could not find rfc6570 library.")}function e(r,n){return new t.UriTemplate(r).stringify(n)}var t;return function(){t=n()}(),e}r.factory("$generateUrl",n),n.$inject=["$window"]}(angular.module("angular-hal.url-generator")); !function(a){"use strict";a.module("angular-hal.resource",["angular-hal.utility","angular-hal.configuration"])}(angular); -!function(e,r){"use strict";function n(e,r,n,t,i,u){function f(o,a){function d(){for(var e in o)o.hasOwnProperty(e)&&(h(e)||t(j,e,o[e]))}function c(){"object"==typeof o[u.linksAttribute]&&Object.keys(o[u.linksAttribute]).forEach(function(e){var r=o[u.linksAttribute][e];E[e]=i(a.config.url,r)})}function s(){"object"==typeof o[u.embeddedAttribute]&&Object.keys(o[u.embeddedAttribute]).forEach(function(e){b(e,o[u.embeddedAttribute][e])})}function l(){w=new e(j,x)}function b(e,r){return Array.isArray(r)?(x[e]=[],void r.forEach(function(r){x[e].push(new f(r,a))})):void(x[e]=new f(r,a))}function h(e){for(var r=0;r",e=[];return r(u.linkParams,function(n,r){n&&e.push(r+'="'+n+'"')}),e.length<1?n:n=n+";"+e.join(";")},this}return t}n.factory("LinkHeader",l),l.$inject=["$q","$extendReadOnly","$injector","$halConfiguration"]}(angular.module("angular-hal.client"),angular.merge,angular.forEach); -!function(e,n,t){"use strict";function r(e,r,i,u){function a(e,n){return f("GET",e,n)}function l(e,n,t){return f("POST",e,n,t)}function o(e,n,t){return f("PUT",e,n,t)}function c(e,n,t){return f("PATCH",e,n,t)}function d(e,n){return f("DELETE",e,n)}function s(e,n,t){return n=n||{},n.headers=n.headers||{},n.headers.Link=t.map(function(e){return e.toString()}),f("LINK",e,n)}function h(e,n,t){return n=n||{},n.headers=n.headers||{},n.headers.Link=t.map(function(e){return e.toString()}),f("UNLINK",e,n)}function f(n,i,a,l){return a=a||{},e.log("The halClient service is deprecated. Please use $http directly instead."),r(t(a,{method:n,url:u.urlTransformer(i),data:l}))}var $=this;!function(){n($,{$get:a,$post:l,$put:o,$patch:c,$delete:d,$del:d,$link:s,$unlink:h,LinkHeader:i})}()}e.service("halClient",r),e.service("$halClient",r),r.$inject=["$log","$http","LinkHeader","$halConfiguration"]}(angular.module("angular-hal.client"),angular.extend,angular.merge); !function(a){"use strict";a.module("angular-hal.http-interception",["angular-hal.resource","angular-hal.configuration"])}(angular); -!function(n,r){"use strict";function t(n){function r(r){return new n(r.data,r)}return r}n.factory("$transformResponseToResource",t),t.$inject=["Resource"]}(angular.module("angular-hal.http-interception"),angular.isArray); +!function(n){"use strict";function t(n){function t(t){return new n(t.data,t)}return t}n.factory("$transformResponseToResource",t),t.$inject=["Resource"]}(angular.module("angular-hal.http-interception")); !function(e){"use strict";function n(e,n){function t(e){return"undefined"==typeof e.headers.Accept?e.headers.Accept=o:e.headers.Accept=[o,e.headers.Accept].join(", "),e}function r(t){return t.headers("Content-Type")===o?e(t):t.config.forceHal?e(t):"application/json"!==t.headers("Content-Type")&&null!==t.headers("Content-Type")||!n.forceJSONResource?t:e(t)}var o="application/hal+json";return{request:t,response:r}}e.factory("ResourceHttpInterceptor",n),n.$inject=["$transformResponseToResource","$halConfiguration"]}(angular.module("angular-hal.http-interception")); !function(t){"use strict";function e(t){t.interceptors.push("ResourceHttpInterceptor")}t.config(e),e.$inject=["$httpProvider"]}(angular.module("angular-hal.http-interception")); !function(a){"use strict";a.module("angular-hal.configuration",[])}(angular); -!function(e){"use strict";function t(){function e(e){c=e}function t(e){a=e}function r(e){d=e}function n(e){d.push(e)}function i(e){l=e}function o(e){b=e}function u(e){g=e}function f(e){return e}function s(e){return g!==f&&e.log("$halConfigurationProvider.setUrlTransformer is deprecated. Please write a http interceptor instead."),Object.freeze({linksAttribute:c,embeddedAttribute:a,ignoreAttributePrefixes:d,selfLink:l,forceJSONResource:b,urlTransformer:g})}var c="_links",a="_embedded",d=["_","$"],l="self",b=!1,g=f;return{setLinksAttribute:e,setEmbeddedAttribute:t,setIgnoreAttributePrefixes:r,addIgnoreAttributePrefix:n,setSelfLink:i,setForceJSONResource:o,setUrlTransformer:u,$get:s}}e.provider("$halConfiguration",t),t.$inject=[]}(angular.module("angular-hal.configuration")); +!function(e){"use strict";function t(){function e(e){c=e}function t(e){a=e}function r(e){d=e}function n(e){d.push(e)}function i(e){l=e}function o(e){b=e}function u(e){g=e}function f(e){return e}function s(e){return g!==f&&e.log("$halConfigurationProvider.setUrlTransformer is deprecated. Please write a http interceptor instead."),Object.freeze({linksAttribute:c,embeddedAttribute:a,ignoreAttributePrefixes:d,selfLink:l,forceJSONResource:b,urlTransformer:g})}var c="_links",a="_embedded",d=["_","$"],l="self",b=!1,g=f;return s.$inject=["$log"],{setLinksAttribute:e,setEmbeddedAttribute:t,setIgnoreAttributePrefixes:r,addIgnoreAttributePrefix:n,setSelfLink:i,setForceJSONResource:o,setUrlTransformer:u,$get:s}}e.provider("$halConfiguration",t),t.$inject=[]}(angular.module("angular-hal.configuration")); +!function(a){"use strict";a.module("angular-hal.client",["angular-hal.utility"])}(angular); +!function(n,r,e){"use strict";function l(){function n(n,l){var u=this;return function(){r(u,{uriReference:n,linkParams:angular.merge({rel:null,anchor:null,rev:null,hreflang:null,media:null,title:null,type:null},l)})}(),u.toString=function(){var n="<"+u.uriReference+">",r=[];return e(u.linkParams,function(n,e){n&&r.push(e+'="'+n+'"')}),r.length<1?n:n=n+";"+r.join(";")},this}return n}n.factory("LinkHeader",l),l.$inject=[]}(angular.module("angular-hal.client"),angular.merge,angular.forEach); +!function(e,n,t){"use strict";function r(e,r,i,u){function a(e,n){return f("GET",e,n)}function l(e,n,t){return f("POST",e,n,t)}function o(e,n,t){return f("PUT",e,n,t)}function c(e,n,t){return f("PATCH",e,n,t)}function d(e,n){return f("DELETE",e,n)}function s(e,n,t){return n=n||{},n.headers=n.headers||{},n.headers.Link=t.map(function(e){return e.toString()}),f("LINK",e,n)}function h(e,n,t){return n=n||{},n.headers=n.headers||{},n.headers.Link=t.map(function(e){return e.toString()}),f("UNLINK",e,n)}function f(n,i,a,l){return a=a||{},e.log("The halClient service is deprecated. Please use $http directly instead."),r(t(a,{method:n,url:u.urlTransformer(i),data:l}))}var $=this;!function(){n($,{$get:a,$post:l,$put:o,$patch:c,$delete:d,$del:d,$link:s,$unlink:h,LinkHeader:i})}()}e.service("halClient",r),e.service("$halClient",r),r.$inject=["$log","$http","LinkHeader","$halConfiguration"]}(angular.module("angular-hal.client"),angular.extend,angular.merge); !function(a){"use strict";a.module("angular-hal",["angular-hal.url-generator","angular-hal.http-interception","angular-hal.client","ng"])}(angular); \ No newline at end of file diff --git a/package.json b/package.json index f1cd24a..bf18981 100644 --- a/package.json +++ b/package.json @@ -25,9 +25,11 @@ "angular-mocks": "~1", "bower": "~1", "connect": "^2.14.4", + "eslint": "^2.3.0", "gulp": "^3.9.1", "gulp-angular-filesort": "^1.1.1", "gulp-concat": "^2.6.0", + "gulp-eslint": "^2.0.0", "gulp-jshint": "^2.0.0", "gulp-uglify": "^1.5.3", "gulp-util": "^3.0.7", @@ -46,6 +48,7 @@ "compile": "./node_modules/gulp/bin/gulp.js", "watch": "./node_modules/gulp/bin/gulp.js watch", "jshint": "./node_modules/gulp/bin/gulp.js jshint", + "eslint": "./node_modules/gulp/bin/gulp.js eslint", "karma": "./node_modules/gulp/bin/gulp.js karma", "test": "./node_modules/gulp/bin/gulp.js test" } diff --git a/src/client/link-header.factory.js b/src/client/link-header.factory.js index 66ea333..bcad0de 100644 --- a/src/client/link-header.factory.js +++ b/src/client/link-header.factory.js @@ -9,21 +9,12 @@ module.factory('LinkHeader', LinkHeaderFactory); // Inject Dependencies - LinkHeaderFactory.$inject = [ - '$q', - '$extendReadOnly', - '$injector', - '$halConfiguration', - ]; + LinkHeaderFactory.$inject = []; /** * Factory for LinkHeader - * @param {Q} $q - * @param {Function} $extendReadOnly - * @param {Injector} $injector Prevent Circular Dependency by injecting $injector instead of $http - * @param {Object} $halConfiguration */ - function LinkHeaderFactory($q, $extendReadOnly, $injector, $halConfiguration) { + function LinkHeaderFactory() { return LinkHeader; /** diff --git a/src/configuration/hal-configuration.provider.js b/src/configuration/hal-configuration.provider.js index bb3467e..fcbbf2b 100644 --- a/src/configuration/hal-configuration.provider.js +++ b/src/configuration/hal-configuration.provider.js @@ -23,6 +23,11 @@ , forceJSONResource = false , urlTransformer = noopUrlTransformer; + // Inject Dependencies + $get.$inject = [ + '$log', + ]; + return { setLinksAttribute: setLinksAttribute, setEmbeddedAttribute: setEmbeddedAttribute, @@ -93,11 +98,6 @@ return url; } - // Inject Dependencies - $get.$inject = [ - '$log', - ]; - /** * @return {Object} */ diff --git a/src/http-interception/response-transformer.service.js b/src/http-interception/response-transformer.service.js index 503e788..99115d0 100644 --- a/src/http-interception/response-transformer.service.js +++ b/src/http-interception/response-transformer.service.js @@ -1,6 +1,5 @@ (function( - module, - isArray + module ) { 'use strict'; @@ -27,6 +26,5 @@ } } })( - angular.module('angular-hal.http-interception'), - angular.isArray + angular.module('angular-hal.http-interception') ); diff --git a/src/resource/resource.factory.js b/src/resource/resource.factory.js index c9c8a7a..dd734ee 100644 --- a/src/resource/resource.factory.js +++ b/src/resource/resource.factory.js @@ -1,6 +1,5 @@ (function( - module, - isArray + module ) { 'use strict'; @@ -181,7 +180,7 @@ * @return {Boolean} */ function $has(rel) { - return $hasLink || $hasEmbedded; + return $hasLink(rel) || $hasEmbedded(rel); } /** @@ -276,6 +275,5 @@ } } })( - angular.module('angular-hal.resource'), - angular.isArray + angular.module('angular-hal.resource') ); diff --git a/test/helpers.js b/test/helpers.js index 15916bc..cbfafeb 100644 --- a/test/helpers.js +++ b/test/helpers.js @@ -1,3 +1,3 @@ -function toObject(resource) { +function toObject(resource) { //eslint-disable-line no-unused-vars return angular.extend({}, resource); } diff --git a/test/integration/halbuilder-test-resources.spec.js b/test/integration/halbuilder-test-resources.spec.js index 0bfc598..77055ab 100644 --- a/test/integration/halbuilder-test-resources.spec.js +++ b/test/integration/halbuilder-test-resources.spec.js @@ -550,7 +550,7 @@ describe('halbuilder test resources', function () { new halClient.LinkHeader('foo', {rel: 'bar', rev: 'baz'}), new halClient.LinkHeader('lorem', {ipsum: 'dolor', sit: 'amet'}), new halClient.LinkHeader('elitr'), - ]).then(function (response) {}); + ]).then(function () {}); $httpBackend.flush(); }); @@ -571,7 +571,7 @@ describe('halbuilder test resources', function () { new halClient.LinkHeader('foo', {rel: 'bar', rev: 'baz'}), new halClient.LinkHeader('lorem', {ipsum: 'dolor', sit: 'amet'}), new halClient.LinkHeader('elitr'), - ]).then(function (response) {}); + ]).then(function () {}); $httpBackend.flush(); }); @@ -606,7 +606,7 @@ describe('halbuilder test resources', function () { new halClient.LinkHeader('elitr'), ]); }) - .then(function (result) {}); + .then(function () {}); $httpBackend.flush(); }); @@ -641,7 +641,7 @@ describe('halbuilder test resources', function () { new halClient.LinkHeader('elitr'), ]); }) - .then(function (result) {}); + .then(function () {}); $httpBackend.flush(); });