Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename documentation file to allow checkout on windows #51

merged 1 commit into from Sep 19, 2019


Copy link

commented Sep 18, 2019

Currently I'm writing a tree-sitter grammar for Lux and I've also set up a CI process for this on Azure Pipelines.

One way in which I test that the grammar is correct is to just parse a bunch of lux code that I know must be valid and check that there are no parsing errors. For now I chose the lux stdlib for this and I added the lux language as a submodule in my tree-sitter grammar repository so I can access the stdlib code during testing.

Now, on Azure Pipelines, tests can be run on Linux, Mac and Windows. However, the checkout of the Lux submodule doesn't work on Windows because there is a file with a name that is invalid on Windows. In particular, '|' (pipe) is not supported in Windows filenames.

This pull request changes the name of the problematic file to a name with underscores instead of pipes

'|' (pipe) is an illegal filename character on windows.
having the pipe would prevent checking out the repository on windows
@eduardoejp eduardoejp merged commit 9277712 into LuxLang:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.