New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: Add CC license to photo #18

Merged
merged 6 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@bennettscience
Contributor

bennettscience commented Nov 26, 2018

Updating the front end to implement the CC license feature request on the main Lychee repo. The UI was updated in two areas:

  1. Sidebar
  • A new section for licensing was added at the bottom of the photo sidebar.
  1. License Modal
  • A popup allows the user to select one of seven preset Creative Commons licenses on their photo
  • If they don't know which license to use, the user can jump to the Creative Commons license picker for help.

I also made a small CSS tweak to make the select element more friendly to the long license titles.

Brian E Bennett added some commits Nov 25, 2018

Brian E Bennett
Tweaked the `.select` class styles
Made the select box a little wider to show more of the option text.
Also made the margin larger to space elements out a little more
nicely.
Brian E Bennett
Select element for adding a license
Created a hard-coded select element on the license modal. Users are
prompted to choose a Creative Commons license when the modal
is launched. They are also provided a link out to the Creative
Commons website to help them choose a license if they've never
used one before.

Addresses #71
Brian E Bennett
Add license info to sidebar
Missing photo metadata in `photo.json` fixed by 1a12a661f1e58b6a811b84434cc04d56cabc3965.
Added the license info to the sidebar with `photo.json.license`.
Show resolved Hide resolved scripts/photo.js Outdated
Show resolved Hide resolved scripts/photo.js
Brian E Bennett
Made requested changes in #18
- Added `None` as a license option and localized
- Localized help URL text

@ildyria ildyria merged commit c8d1c88 into LycheeOrg:master Nov 26, 2018

@ildyria

This comment has been minimized.

Collaborator

ildyria commented Nov 26, 2018

Thank you. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment