From fa00985ff17141fd6ef6de9d93d502f4d612cd03 Mon Sep 17 00:00:00 2001 From: Matteo Paonessa Date: Tue, 22 Feb 2022 19:34:21 +0100 Subject: [PATCH] Minor inspection fixes --- .clang-format | 10 +++++----- src/models/CImage.cpp | 2 +- src/updater/osx/CocoaInitializer.mm | 2 -- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.clang-format b/.clang-format index 2bda407..99445cb 100644 --- a/.clang-format +++ b/.clang-format @@ -3,8 +3,8 @@ Language: Cpp # BasedOnStyle: WebKit AccessModifierOffset: -4 AlignAfterOpenBracket: DontAlign -AlignConsecutiveAssignments: false -AlignConsecutiveDeclarations: false +AlignConsecutiveAssignments: None +AlignConsecutiveDeclarations: None AlignEscapedNewlines: Right AlignOperands: false AlignTrailingComments: false @@ -26,7 +26,7 @@ BinPackParameters: true BraceWrapping: AfterCaseLabel: false AfterClass: false - AfterControlStatement: false + AfterControlStatement: Never AfterEnum: false AfterFunction: true AfterNamespace: false @@ -98,7 +98,7 @@ PenaltyExcessCharacter: 1000000 PenaltyReturnTypeOnItsOwnLine: 60 PointerAlignment: Left ReflowComments: true -SortIncludes: true +SortIncludes: CaseSensitive SortUsingDeclarations: true SpaceAfterCStyleCast: false SpaceAfterLogicalNot: false @@ -116,7 +116,7 @@ SpacesInContainerLiterals: true SpacesInCStyleCastParentheses: false SpacesInParentheses: false SpacesInSquareBrackets: false -Standard: Cpp11 +Standard: c++17 StatementMacros: - Q_UNUSED - QT_REQUIRE_VERSION diff --git a/src/models/CImage.cpp b/src/models/CImage.cpp index f14bca4..db59eee 100644 --- a/src/models/CImage.cpp +++ b/src/models/CImage.cpp @@ -173,7 +173,7 @@ bool CImage::compress(const CompressionOptions& compressionOptions) QFileInfo outputInfo(tempFileFullPath); bool outputIsBiggerThanInput = outputInfo.size() >= inputFileInfo.size(); - bool copyResult = false; + bool copyResult; if (outputAlreadyExists) { QFile::remove(outputFullPath); diff --git a/src/updater/osx/CocoaInitializer.mm b/src/updater/osx/CocoaInitializer.mm index ab844eb..31d3eed 100644 --- a/src/updater/osx/CocoaInitializer.mm +++ b/src/updater/osx/CocoaInitializer.mm @@ -5,8 +5,6 @@ #include "CocoaInitializer.h" #include -#include -#include class CocoaInitializer::Private {