Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images attached to posts that haven't federated yet aren't detected #8

Closed
Lynnesbian opened this issue Feb 26, 2019 · 4 comments

Comments

Projects
None yet
1 participant
@Lynnesbian
Copy link
Owner

commented Feb 26, 2019

As the title says

@Lynnesbian Lynnesbian added the bug label Feb 26, 2019

@Lynnesbian Lynnesbian self-assigned this Feb 26, 2019

@Lynnesbian

This comment has been minimized.

Copy link
Owner Author

commented Mar 28, 2019

If a post hasn't federated yet, it will have an in_reply_to_id of None. We need to check for this, and then somehow obtain the reply ID through other means.

@Lynnesbian

This comment has been minimized.

Copy link
Owner Author

commented May 2, 2019

the ID could be obtained by viewing the reply on its source instance, using that to obtain the reply ID, and then fetching the reply that way

it would require checking at least one separate instances, and would break if it the instance wasn't compatible with the mastodon API, but i think it's our best bet

@Lynnesbian

This comment has been minimized.

Copy link
Owner Author

commented May 10, 2019

i think, and i really hope, that this has been fixed. i haven't seen OCRbot posting the dreaded federation error so far. i won't mark it as closed quite yet, but i'm hopeful. i think 108c224 actually worked

@Lynnesbian

This comment has been minimized.

Copy link
Owner Author

commented May 14, 2019

fixed!

@Lynnesbian Lynnesbian closed this May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.