Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide version rewrite using a regex pattern and replacement. #1

Merged
merged 1 commit into from Mar 22, 2017

Conversation

@boombatower
Copy link

boombatower commented Dec 17, 2016

Nicely rewrite the very common v1.0.0 style tags to 1.0.0 which works properly with rpm %setup and set_version service.

@boombatower

This comment has been minimized.

Copy link
Author

boombatower commented Dec 17, 2016

Successfully applied to one of my packages that has to deal with the silly v prefix.

https://build.opensuse.org/request/show/446795

@aspiers

This comment has been minimized.

Copy link

aspiers commented Dec 31, 2016

@boombatower This change looks plausible but why are you submitting it to this fork instead of to the official repository? As you are already aware, there is ongoing work in the latter repo on this topic. It would be great to solve this in a converged way which works for everyone.

@boombatower

This comment has been minimized.

Copy link
Author

boombatower commented Jan 16, 2017

Factory was using this repo as a source instead of the "official" one not to mention this one is significantly different in structure. Without any explanation anywhere it seemed this was the place to send it. Why is Factory using this fork if it does not represent the directory of the repo?

@aspiers

This comment has been minimized.

Copy link

aspiers commented Jan 18, 2017

Why is Factory using this fork if it does not represent the directory of the repo?

I'm not entirely sure, and ideally it would have never happened. In any case I will be working with Frank soon to reconverge the two branches so we shouldn't have this problem again in the future.

@boombatower

This comment has been minimized.

Copy link
Author

boombatower commented Jan 26, 2017

So this needs to wait until merged to be considered then?

@aspiers

This comment has been minimized.

Copy link

aspiers commented Jan 26, 2017

Yes but I'm making good progress on the reconvergence now.

@M0ses

This comment has been minimized.

Copy link
Owner

M0ses commented Mar 22, 2017

LGTM

@M0ses M0ses merged commit c19c395 into M0ses:nextRev Mar 22, 2017
@M0ses

This comment has been minimized.

Copy link
Owner

M0ses commented Mar 23, 2017

@boombatower - Thanks for you contribution and sorry for delay. New packages should be available in openSUSE:Tools and will be shipped in next maintenance window (hopefully next Thursday).

I added some test cases to make sure, your feature works and avoid regressions:

8d6254e

@boombatower

This comment has been minimized.

Copy link
Author

boombatower commented Mar 29, 2017

Sweet!

@boombatower boombatower deleted the boombatower:rewrite branch Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.