Replace usage of android.net.MailTo with androidx.core.net.MailTo #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the AndroidX version of MailTo instead of the broken platform version. For more information see https://cketti.de/2020/06/22/android-net-mailto-is-broken/
Owner
|
Thanks for this. In fact there are a few workarounds for the described problems. I am a bit worried that other things break though, so I will need to look into this a bit deeper and do some test first. |
Owner
|
@cketti The AndroidX MailTo implementation is not entirely correct either. It uses Uri.decode, which in turn uses UriCodec.decode with UTF-8 as character set, which means that for example %ab will be decoded into an invalid UTF-8 character. Hence: https://github.com/M66B/FairEmail/blob/master/app/src/main/java/eu/faircode/email/MailTo.java |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the AndroidX version of
MailToinstead of the broken platform version.For more information see https://cketti.de/2020/06/22/android-net-mailto-is-broken/