Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Git-Attributes file #52

Closed
wants to merge 1 commit into from
Closed

Add Git-Attributes file #52

wants to merge 1 commit into from

Conversation

@thePanz
Copy link
Contributor

thePanz commented Oct 29, 2018

No description provided.

/Dockerfile export-ignore
/docker export-ignore
/docker-compose.yml export-ignore
/phpunit.xml.dist export-ignore

This comment has been minimized.

Copy link
@Tobion

Tobion Feb 5, 2020

Contributor

this file does not exist as the bundle seems to use atoum for testing instead of phpunit

Copy link
Member

Oliboy50 left a comment

@thePanz 👋 hi

I'm sorry but we're not used to the .gitattributes file (speaking for myself, I've never set one in any of my projects yet)

maybe you have a good explanation that will help us to know why this project needs this file?

FTR:
https://git-scm.com/docs/gitattributes#_code_export_ignore_code

Creating an archive
export-ignore

Files and directories with the attribute export-ignore won’t be added to archive files.

@Meroje Meroje closed this Feb 6, 2020
@Meroje

This comment has been minimized.

Copy link

Meroje commented Feb 6, 2020

Sorry for the close I missclicked, I intended to click in the comment textarea 😅

@Oliboy50 the exports-ignore directive makes it so that these files are removed from zip and tarballs of the repo, presumably because it makes the vendor folder cleaner or lighter for the author because they're not needed to use the bundle. I don't see big savings here though.

Tobion added a commit to Tobion/AmqpBundle that referenced this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.