Some cleanup #25

Open
wants to merge 1 commit into
from

Projects

None yet

4 participants

@lyrixx
lyrixx commented Feb 9, 2017

No description provided.

@@ -14,7 +14,7 @@
"symfony/framework-bundle" : "~3.0"
},
"require-dev" : {
- "atoum/atoum" : "master-dev",
+ "atoum/atoum" : "dev-master",
@omansour
omansour Feb 9, 2017 Member

^^ we should use the last stable version of atoum :)

@lyrixx
lyrixx Feb 9, 2017

BTW, atoum is not compatible with PHP 7.1. So I was not able to run the test suite locally... The issue is almost 1 year old :/

@lucascourot
lucascourot Feb 10, 2017 Member

Yeah it is unfortunate :/

@@ -29,6 +29,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
protected function myCallback(InputInterface $input, OutputInterface $output)
{
- $this->countCall++;
+ ++$this->countCall;
@Oliboy50
Oliboy50 Feb 9, 2017 Member

what's the point of changing this?
it doesn't change anything IMHO, since we don't use any return statement here

@lyrixx
lyrixx Feb 9, 2017

Actually, this code has been updated when using php-cs-fixer with the @Symfony rules set.

pre_increment [@Symfony]
Pre incrementation/decrementation should be used if possible.

@Oliboy50

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment