Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset helper #18

Closed
lolamtisch opened this issue Nov 1, 2018 · 4 comments
Closed

Offset helper #18

lolamtisch opened this issue Nov 1, 2018 · 4 comments
Labels
enhancement

Comments

@lolamtisch
Copy link
Member

@lolamtisch lolamtisch commented Nov 1, 2018

Although while I switched from the userscript to the extension, the offsets that I fixed previously were reset.
Since the extension now loads hidden tabs to detect the last episode could it also detect the first one and set offsets accordingly? Something like an auto offset option.

Originally posted by @Eskander in #8 (comment)

@lolamtisch
Copy link
Member Author

@lolamtisch lolamtisch commented Nov 1, 2018

@Eskander
I would say it is a bit too risky like that.
But adding a popup recommending a possible offset when opening a overview streaming page should do the job.

@lolamtisch lolamtisch added the enhancement label Nov 1, 2018
@lolamtisch lolamtisch added this to backlog in Features via automation Nov 1, 2018
@Eskander
Copy link

@Eskander Eskander commented Nov 1, 2018

Why would that be risky? If anything goes wrong the user will have to set the value manually and the extension should ignore updating manually set offsets. Maybe a switch to set a manual offset would be needed in that case.
Besides, the new Update Check feature is giving some wrong values because of the unset offsets.

@lolamtisch
Copy link
Member Author

@lolamtisch lolamtisch commented Nov 1, 2018

There is so much that can go wrong, because many pages use pagination, ajax pagination etc..
I dont trust my implementation enought, for such a critical value.
Especially for a new user a wrong offset is a lot more confusing than a missing offset. For me a user confirmation is a must here.

UpdateCheck:
You can check the state in the debugging page of the updateCheck settings. Finished entrys are not checked again. So the entrys with a wrong offset are probably marked as finished and will stay like that.

Current Workaround:
There is no other way atm than using the "clear cache" button in miniMAL to reset the update check entries. This unfortunately deletes the offset values too. So you will have to set them all again and then restart the updateCheck.
This workaround is more then suboptimal i would say. Will be better with the next update.

TODOs:
Add buttons to the debugging page to reset individual entries
Reset updateCheck entry on offset change.
Move offset variables into the permanent sync storage

@Eskander
Copy link

@Eskander Eskander commented Nov 1, 2018

Finished entrys are not checked again. So the entrys with a wrong offset are probably marked as finished and will stay like that.

That's exactly what was happening. Following the Current Workaround fixes the issue. Thanks.

@lolamtisch lolamtisch moved this from backlog to Planned for next release in Features Jan 4, 2019
lolamtisch added a commit that referenced this issue Jan 4, 2019
@lolamtisch lolamtisch moved this from Planned for next release to Done for next release in Features Jan 4, 2019
@lolamtisch lolamtisch moved this from Done for next release to Done in Features Jan 6, 2019
SwagOtaku added a commit to SwagOtaku/MALSync that referenced this issue May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
Features
  
Done
Development

No branches or pull requests

2 participants