Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2,1.14.4] Too large nbt tags send to client #22

Closed
HyCraftHD opened this issue Oct 7, 2019 · 3 comments

Comments

@HyCraftHD
Copy link
Member

commented Oct 7, 2019

Describe the bug
If a mod uses lots of nbt tags the backpack will send them always to the client because currently we sync every nbt tag to the client. This behaviour is very bad and therefore the should implement

getNBTShareTag(ItemStack stack) / getShareTag(ItemStack stack)

to remove the inventory from being sent to the client.

To Reproduce
Steps to reproduce the behavior:

  1. Use a mod that uses lots of nbt tags on items
  2. Store them in a backpack
  3. If running on a server this may break the packsize and deny the login from a player.

Expected behavior
Should not happen, lol 😳

Screenshots
Something like this:
image

Versions

  • Mod version: 1.12.2-1.5.1.35 / 1.14.4-1.7.1.36
  • Minecraft version: 1.12.2 / 1.14.4
  • Forge version: Every forge version
  • UTeamCore version: Irrelevant

Log (if crash occures)
Link to crash log

@HyCraftHD HyCraftHD added the bug label Oct 7, 2019
HyCraftHD added a commit that referenced this issue Oct 7, 2019
@HyCraftHD HyCraftHD closed this in b549b73 Oct 7, 2019
@KalderiusUSA

This comment has been minimized.

Copy link

commented Oct 9, 2019

Can you figure what is wrong? Your Useful Backpacks mod is the only one not working properly... What happens is that when you open a backpack and move your move onto it, the game kicks you with an error. The following is the error:

The game crashed whilst exception in server tick loop
Error" java.lang.NoSuchMethodError:
net.minecraft.entity.player.PlayerEntity.getEntityData()Lnet/minecraft/nbt/CompoundNBT

---- Minecraft Crash Report ----
// I bet Cylons wouldn't have this problem.

Time: 10/9/19 5:55 AM
Description: Exception in server tick loop

java.lang.NoSuchMethodError: net.minecraft.entity.player.PlayerEntity.getEntityData()Lnet/minecraft/nbt/CompoundNBT;
at net.blay09.mods.trashslot.TrashHelper.getTrashItem(TrashHelper.java:19) ~[?:10.4.5] {}
at net.blay09.mods.trashslot.TrashSlot.onPlayerOpenContainer(TrashSlot.java:89) ~[?:10.4.5] {}
at net.minecraftforge.eventbus.ASMEventHandler_136_TrashSlot_onPlayerOpenContainer_Open.invoke(.dynamic) ~[?:?] {}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:80) ~[eventbus-1.0.0-service.jar:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:258) ~[eventbus-1.0.0-service.jar:?] {}
at net.minecraftforge.fml.network.NetworkHooks.openGui(NetworkHooks.java:182) ~[?:?] {}
at info.u_team.useful_backpacks.item.BackpackItem.func_77659_a(BackpackItem.java:31) ~[?:1.7.0.34] {}
at net.minecraft.item.ItemStack.func_77957_a(ItemStack.java:192) ~[?:?] {}
at net.minecraft.server.management.PlayerInteractionManager.func_187250_a(PlayerInteractionManager.java:273) ~[?:?] {}
at net.minecraft.network.play.ServerPlayNetHandler.func_147346_a(ServerPlayNetHandler.java:865) ~[?:?] {}
at net.minecraft.network.play.client.CPlayerTryUseItemPacket.func_148833_a(SourceFile:32) ~[?:?] {}
at net.minecraft.network.play.client.CPlayerTryUseItemPacket.func_148833_a(SourceFile:9) ~[?:?] {}
at net.minecraft.network.PacketThreadUtil.lambda$checkThreadAndEnqueue$0(PacketThreadUtil.java:33) ~[?:?] {xf:OptiFine:default}
at net.minecraft.network.PacketThreadUtil$$Lambda$5439/997082431.run(Unknown Source) ~[?:?] {}
at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?] {}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(ThreadTaskExecutor.java:170) ~[?:?] {pl:accesstransformer:B,xf:OptiFine:default}
at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?] {}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(ThreadTaskExecutor.java:135) ~[?:?] {pl:accesstransformer:B,xf:OptiFine:default}
at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:699) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:693) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(ThreadTaskExecutor.java:115) ~[?:?] {pl:accesstransformer:B,xf:OptiFine:default}
at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:678) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:626) [?:?] {pl:accesstransformer:B}
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- System Details --
Details:
Minecraft Version: 1.14.4
Minecraft Version ID: 1.14.4
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 5720339936 bytes (5455 MB) / 8589934592 bytes (8192 MB) up to 8589934592 bytes (8192 MB)
CPUs: 8
JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx8G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
ModLauncher: 3.2.0+60+b86c1d4
ModLauncher launch target: fmlclient
ModLauncher naming: srg
ModLauncher services:
/eventbus-1.0.0-service.jar eventbus PLUGINSERVICE
/forge-1.14.4-28.1.0.jar object_holder_definalize PLUGINSERVICE
/forge-1.14.4-28.1.0.jar runtime_enum_extender PLUGINSERVICE
/accesstransformers-1.0.0-shadowed.jar accesstransformer PLUGINSERVICE
/forge-1.14.4-28.1.0.jar capability_inject_definalize PLUGINSERVICE
/forge-1.14.4-28.1.0.jar runtimedistcleaner PLUGINSERVICE
/preview_OptiFine_1.14.4_HD_U_F4_pre7.jar OptiFine TRANSFORMATIONSERVICE
/forge-1.14.4-28.1.0.jar fml TRANSFORMATIONSERVICE
FML: 28.1
Forge: net.minecraftforge:28.1.0
FML Language Providers:
javafml@28.1
minecraft@1
kotori_scala@2.12.9
Mod List:
AmbientSounds_v3.0.9_mc1.14.4.jar Ambient Sounds {ambientsounds@3.0.3 DONE}
BiomesOPlenty-1.14.4-9.0.0.236-universal.jar Biomes O' Plenty {biomesoplenty@1.14.4-9.0.0.236 DONE}
Chicken-Drop-Feathers-1.14.4.jar Chicken Drop Feathers {chickendropfeathersmod@2.0 DONE}
Corail-Pillar-Extension-Biomes-O-Plenty-Mod-1.14.4.jar Corail Pillar - Biomes O'Plenty Extension {corail_pillar_extension_biomesoplenty@4.2.0 DONE}
Corail-Woodcutter-1.14.4.jar Corail Woodcutter {corail_woodcutter@1.0.1 DONE}
corail_pillar-4.5.3-1.14.4.jar Corail Pillar {corail_pillar@4.5.3 DONE}
create-mc1.14.4_v0.0.5.jar Create {create@0.0.5 DONE}
CyclopsCore-1.14.4.jar Cyclops Core {cyclopscore@1.5.3 DONE}
Extended-Caves-Mod-1.14.4.jar Extended Caves {extcaves@1.2 DONE}
Extended-Lights-1.14.4.jar Extended Lights {extlights@1.2 DONE}
FastFurnace-Mod-1.14.4.jar FastFurnace {fastfurnace@2.0.0 DONE}
FastLeafDecay-v17.jar FastLeafDecay {fastleafdecay@v17 DONE}
forgemod_VoxelMap-1.9.13b_for_1.14.4.jar VoxelMap {voxelmap@1.9.13 DONE}
JRFTL+[1.14.4]-1.1.jar JRFTL {jrftl@1.1 DONE}
lumberjack_1.14.4_2.0.0.jar LumberJack {lumberjack@2.0.0 DONE}
metalbarrels-1.3c.jar Metal Barrels {metalbarrels@1.3c DONE}
Placebo-1.14.4-2.1.11.jar Placebo {placebo@2.1.11 DONE}
Pretty-Beaches-Mod-1.14.4.jar Pretty Beaches {prettybeaches@3.0.6 DONE}
Remove-Mouseover-Highlight-Mod-1.14.4.jar Remove Mouseover Highlight {rmh@0.0.1 DONE}
Seafaring-1.14.4.jar Seafaring {sea@0.1.44 DONE}
Sign-Button-Mod-1.14.4.jar Sign Button {signbutton@version DONE}
Simple-Diving-Gear-Mod-1.14.4.jar Simple Diving Gear {simpledivegear@3.0.0 mc 1.14.4 DONE}
ToastControl-1.14.4-2.1.2.jar Toast Control {toastcontrol@2.1.2 DONE}
tombstone-3.7.5-1.14.4.jar Corail Tombstone {tombstone@3.7.5 DONE}
Torchplacer-1.14.4.jar Torchplacer {torchpl@1.0.1 DONE}
TrashSlot-Mod-1.14.4.jar TrashSlot {trashslot@10.4.5 DONE}
U-Team-Core-1.14.4.jar U Team Core {uteamcore@2.7.0.129 DONE}
Uncle-Gs-Glass-Mod-1.14.4.jar Uncle George's Glass {unclegglass@2.0.0 DONE}
Useful-Backpacks-Mod-1.14.4.jar Useful Backpacks {usefulbackpacks@1.7.0.34 DONE}
Wild-Nature-Mod-1.14.4.jar WildNature Mod {wildnature@2.0.5 DONE}
worldedit-forge-mc1.14.4-7.0.1.jar WorldEdit {worldedit@7.0.1;61bc012 DONE}
forge-1.14.4-28.1.0-universal.jar Forge {forge@28.1.0 DONE}
forge-1.14.4-28.1.0-client.jar Minecraft {minecraft@1.14.4 DONE}
Player Count: 1 / 8; [ServerPlayerEntity['KalderiusUSA'/74, l='Dad's 9/19/19', x=3174.86, y=37.00, z=2362.57]]
Data Packs: mod:unclegglass, mod:rmh, mod:worldedit, mod:wildnature, mod:voxelmap, mod:uteamcore, mod:usefulbackpacks, mod:trashslot, mod:torchpl, mod:tombstone, mod:toastcontrol, mod:simpledivegear, mod:signbutton, mod:sea, mod:prettybeaches, mod:placebo, mod:metalbarrels, mod:lumberjack (incompatible), mod:jrftl (incompatible), mod:forge, mod:fastleafdecay, mod:fastfurnace, mod:extlights, mod:extcaves, mod:cyclopscore, mod:create, mod:corail_woodcutter, mod:corail_pillar_extension_biomesoplenty, mod:corail_pillar, mod:chickendropfeathersmod, mod:biomesoplenty, mod:ambientsounds, vanilla
Type: Integrated Server (map_client.txt)
Is Modded: Definitely; Client brand changed to 'forge'

@HyCraftHD

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

Please open a new issue and don't hop in other issues with your issue.

@HyCraftHD

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

Also just to let you know. This issue is not caused by the backpack mod but by the trash slot mod.
An issue can be found here: blay09/TrashSlot#56

HyCraftHD added a commit that referenced this issue Oct 12, 2019
HyCraftHD added a commit that referenced this issue Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.