Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #7: use access transformer to get the age of EntityItem. #8

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@duely
Copy link

commented Sep 1, 2019

Otherwise it violates the siding, as the getAge accessor it annotated
as being client-side only. As this value updates on both the server and
client sides, I'm not entirely sure what the reasoning was on it.

Regardless, this prevents the teleport rail from crashing in a
multiplayer server.

Resolve #7: use access transformer to get the age of EntityItem.
Otherwise it violates the siding, as the `getAge` accessor it annotated
as being client-side only. As this value updates on both the server and
client sides, I'm not entirely sure what the reasoning was on it.

Regardless, this prevents the teleport rail from crashing in a
multiplayer server.

@MrTroble MrTroble requested review from HyCraftHD and MrTroble Sep 1, 2019

@MrTroble

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

Thank you very much for your pull request we will take a look into it shortly.

Cheers
~MrTroble

@MrTroble MrTroble added the bug label Sep 1, 2019

@duely

This comment has been minimized.

Copy link
Author

commented Sep 1, 2019

I stupidly missed the second call to getAge as I was editing in vim rather than my IDE. Whoops! I've updated it with an additional commit to the branch.

@MrTroble

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

No worries, we are glad that you help use :)
I am setting up the whole thing to review it.

Cheers
~MrTroble

@MrTroble

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

One sec

@HyCraftHD HyCraftHD merged commit 3c47834 into MC-U-Team:1.12.2 Sep 2, 2019

@MrTroble

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

This should Fix #7

HyCraftHD added a commit that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.