Skip to content

[rack-falcon] Remove request method guard #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MDA2AV merged 2 commits into from
May 21, 2026
Merged

[rack-falcon] Remove request method guard #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8006b04
[rack-falcon] Remove request method guard
p8 May 21, 2026
cbff946
Benchmark results: rack-falcon
github-actions[bot] May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions frameworks/rack-falcon/app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,30 +7,25 @@
class App
CONTENT_TYPE = 'Content-Type'
PLAINTEXT_TYPE = 'text/plain'
KNOWN = %w[GET POST PUT DELETE PATCH HEAD OPTIONS TRACE CONNECT].freeze

def call(env)
if KNOWN.include?(env['REQUEST_METHOD'])
case env['PATH_INFO']
when '/pipeline'
render_plain 'ok'
when '/baseline11'
params = Rack::Utils.parse_query(env['QUERY_STRING'])
total = params['a'].to_i + params['b'].to_i
if env['REQUEST_METHOD'] == 'POST'
body = env["rack.input"]&.read
total += body.to_i
end
render_plain total.to_s
when '/baseline2'
params = Rack::Utils.parse_query(env['QUERY_STRING'])
total = params['a'].to_i + params['b'].to_i
render_plain total.to_s
else
[404, {CONTENT_TYPE => PLAINTEXT_TYPE}, ['Not found!']]
case env['PATH_INFO']
when '/pipeline'
render_plain 'ok'
when '/baseline11'
params = Rack::Utils.parse_query(env['QUERY_STRING'])
total = params['a'].to_i + params['b'].to_i
if env['REQUEST_METHOD'] == 'POST'
body = env["rack.input"]&.read
total += body.to_i
end
render_plain total.to_s
when '/baseline2'
params = Rack::Utils.parse_query(env['QUERY_STRING'])
total = params['a'].to_i + params['b'].to_i
render_plain total.to_s
else
[405, {CONTENT_TYPE => PLAINTEXT_TYPE}, ['Method Not Allowed']]
[404, {CONTENT_TYPE => PLAINTEXT_TYPE}, ['Not found!']]
end
end

Expand Down
20 changes: 20 additions & 0 deletions site/data/baseline-4096.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,26 @@
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-falcon",
"language": "Ruby",
"rps": 550257,
"avg_latency": "7.45ms",
"p99_latency": "11.90ms",
"cpu": "6547.7%",
"memory": "1.3GiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 1,
"bandwidth": "46.69MB/s",
"input_bw": "42.51MB/s",
"reconnects": 0,
"status_2xx": 2751285,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-iodine",
"language": "Ruby",
Expand Down
20 changes: 20 additions & 0 deletions site/data/baseline-512.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,26 @@
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-falcon",
"language": "Ruby",
"rps": 576090,
"avg_latency": "888us",
"p99_latency": "1.79ms",
"cpu": "6576.0%",
"memory": "1.2GiB",
"connections": 512,
"threads": 64,
"duration": "5s",
"pipeline": 1,
"bandwidth": "48.88MB/s",
"input_bw": "44.50MB/s",
"reconnects": 0,
"status_2xx": 2880451,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-iodine",
"language": "Ruby",
Expand Down
20 changes: 20 additions & 0 deletions site/data/limited-conn-4096.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,26 @@
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-falcon",
"language": "Ruby",
"rps": 496292,
"avg_latency": "8.19ms",
"p99_latency": "71.60ms",
"cpu": "6544.9%",
"memory": "1.3GiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 1,
"bandwidth": "42.11MB/s",
"input_bw": "38.34MB/s",
"reconnects": 248097,
"status_2xx": 2481460,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-iodine",
"language": "Ruby",
Expand Down
20 changes: 20 additions & 0 deletions site/data/limited-conn-512.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,26 @@
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-falcon",
"language": "Ruby",
"rps": 497281,
"avg_latency": "1.02ms",
"p99_latency": "2.03ms",
"cpu": "6569.5%",
"memory": "1.3GiB",
"connections": 512,
"threads": 64,
"duration": "5s",
"pipeline": 1,
"bandwidth": "42.20MB/s",
"input_bw": "38.41MB/s",
"reconnects": 248638,
"status_2xx": 2486409,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-iodine",
"language": "Ruby",
Expand Down
19 changes: 19 additions & 0 deletions site/data/pipelined-4096.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,25 @@
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-falcon",
"language": "Ruby",
"rps": 800040,
"avg_latency": "81.44ms",
"p99_latency": "147.50ms",
"cpu": "6594.3%",
"memory": "1.0GiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 16,
"bandwidth": "67.89MB/s",
"reconnects": 0,
"status_2xx": 4000203,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-iodine",
"language": "Ruby",
Expand Down
19 changes: 19 additions & 0 deletions site/data/pipelined-512.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,25 @@
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-falcon",
"language": "Ruby",
"rps": 868025,
"avg_latency": "9.44ms",
"p99_latency": "14.20ms",
"cpu": "6723.8%",
"memory": "716MiB",
"connections": 512,
"threads": 64,
"duration": "5s",
"pipeline": 16,
"bandwidth": "73.66MB/s",
"reconnects": 0,
"status_2xx": 4340127,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
{
"framework": "rack-iodine",
"language": "Ruby",
Expand Down
74 changes: 74 additions & 0 deletions site/static/logs/baseline/4096/rack-falcon.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Falcon::Command::Host","object_id":896,"message":"Falcon Host v0.54.2 taking flight!\n- Configuration: falcon.rb\n- To terminate: Ctrl-C or kill 1\n- To reload: kill -HUP 1\n"}
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Container::Notify::Console","object_id":904,"message":{"status":"Initializing controller..."}}
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Falcon::Service::Server","object_id":920,"message":"Starting app on #<Async::HTTP::Endpoint http://0.0.0.0:8080/ {protocol: Async::HTTP::Protocol::HTTP11}>"}
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Controller starting..."}
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Starting container..."}
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Waiting for startup..."}
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Finished startup."}
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Container::Notify::Console","object_id":904,"message":{"ready":true,"size":65}}
{"time":"2026-05-21T21:12:41+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Controller started..."}
Loading