New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_transformation isn't thread save and coverage fluctuates #1449

Open
kain88-de opened this Issue Jul 1, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@kain88-de
Member

kain88-de commented Jul 1, 2017

Expected behaviour

Running test_transformations should always result in the same coverage. Independent of the number of processes used.

Actual behaviour

Coverage fluctuates on different runs. We see that sometimes we get a decrease in coverage and it's always on the transformation files. The problem is that we use random number on these tests and neither the pure python nor the c version is thread save.

Fix

To fix it we always need to give the functions a fixed random number as the rand parameter.

Currently version of MDAnalysis:

develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment