New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtomGroup.dimensions returns view sometimes #1582

Closed
richardjgowers opened this Issue Aug 4, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@richardjgowers
Member

richardjgowers commented Aug 4, 2017

AtomGroup.dimensions should always return a copy of the dimensions information for a given timestep

For this issue:

  • create tests which loop over all Timestep object formats and check that a copy is returned

related #1575

@orbeckst

This comment has been minimized.

Show comment
Hide comment
@orbeckst

orbeckst Aug 15, 2017

Member

See #1575 (comment) in particular.

Member

orbeckst commented Aug 15, 2017

See #1575 (comment) in particular.

@orbeckst

This comment has been minimized.

Show comment
Hide comment
@orbeckst

orbeckst Aug 15, 2017

Member

@richardjgowers is this issue for creating tests and then #1575 is for fixing the issue?

Member

orbeckst commented Aug 15, 2017

@richardjgowers is this issue for creating tests and then #1575 is for fixing the issue?

@richardjgowers

This comment has been minimized.

Show comment
Hide comment
@richardjgowers

richardjgowers Aug 15, 2017

Member

@orbeckst I think #1575 is more about Timestep, so I made this to deal with the AtomGroup.dimensions issue. Fixing #1575 might fix this too, but they're independent in terms of (esp. black box) tests

Member

richardjgowers commented Aug 15, 2017

@orbeckst I think #1575 is more about Timestep, so I made this to deal with the AtomGroup.dimensions issue. Fixing #1575 might fix this too, but they're independent in terms of (esp. black box) tests

@orbeckst

This comment has been minimized.

Show comment
Hide comment
@orbeckst

orbeckst Aug 15, 2017

Member

Good point, Timestep.dimensions vs AtomGroup.dimensions... if we implement #1575 (comment) then Timestep.dimensions would always be a view and AtomGroup.dimensions should just point to it. Then we would be done.

Member

orbeckst commented Aug 15, 2017

Good point, Timestep.dimensions vs AtomGroup.dimensions... if we implement #1575 (comment) then Timestep.dimensions would always be a view and AtomGroup.dimensions should just point to it. Then we would be done.

richardjgowers added a commit that referenced this issue Jan 30, 2018

@jbarnoud jbarnoud closed this in #1764 Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment